Repository navigation
fix(release): keep Release Please lineage current - #23
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe release workflow now reconciles Release Please labels for the admitted pull request. Integration tests validate permissions, idempotent updates, deletion failures, and stale-label convergence failures. ChangesRelease lineage reconciliation
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ReleaseJob
participant GhCLI
participant AdmittedPullRequest
ReleaseJob->>GhCLI: identify admitted pull request
ReleaseJob->>GhCLI: add autorelease: tagged
ReleaseJob->>GhCLI: remove autorelease: pending
GhCLI->>AdmittedPullRequest: read final labels
AdmittedPullRequest-->>ReleaseJob: return label state
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/release-validate.test.ts`:
- Around line 417-438: Update the fake GitHub CLI fixture handling POST requests
in the stale_labels branch so it still records the requested label, allowing
autorelease: tagged to be added alongside the existing autorelease: pending
label. Keep the stale_labels DELETE path as a successful no-op, preserving the
non-convergent state with both labels present.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 741cb989-a0f9-49f8-a8ee-7fb2baa103f2
📒 Files selected for processing (2)
.github/workflows/release.ymlscripts/release-validate.test.ts
Summary
Release maintenance no longer stalls on a release that was already published by the custom workflow. After publication or repair completes all immutable tag, asset, and attestation checks, the workflow now marks the provenance-bound Release Please PR as
autorelease: taggedand removesautorelease: pending.The reconciliation is idempotent and fail-closed. Its executable regression covers the actual label payload, first-run convergence, retry behavior, permission-style DELETE failure, and stale final state.
Validation
bun test: 524 passed, 3 explicit manual/hosted skips, 0 failedbun test scripts/release-validate.test.ts: 41 passedactionlint .github/workflows/release.yml: cleangit diff --check: cleanHosted qualification after merge: run the existing
v0.1.1repair lane to reconcile PR #18, then run maintenance and confirm Release Please opens the expected0.2.0release PR.Summary by CodeRabbit
Chores
Tests