Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Add missing <Head> #3939

Merged
merged 1 commit into from
Aug 18, 2024
Merged

[website] Add missing <Head> #3939

merged 1 commit into from
Aug 18, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 17, 2024 •
edited
Loading

https://master--mui-toolpad-docs.netlify.app/toolpad/ has no title, og:image, description, etc.
This was removed in #3868. I thought I would open a PR directly, it was as fast as reporting it.

Side observations:

  • We need to create og images for toolpad core
  • The h1 is truncated in the first HTML render: "Full stack components for React"

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation bug 🐛 Something doesn't work regression A bug, but worse labels Aug 17, 2024
@Janpot
Copy link
Member

Janpot commented Aug 18, 2024 •
edited
Loading

Thank you, I believe this was also addressed in #3928

@oliviertassinari
Copy link
Member Author

Thank you, I believe this was also addressed in #3928

Ah oops, I searched for "website" label PRs, why I didn't saw this one.

@oliviertassinari oliviertassinari added the website Related to the marketing pages label Aug 18, 2024
@oliviertassinari oliviertassinari changed the title [docs] Add missing <Head> [website] Add missing <Head> Aug 18, 2024
@oliviertassinari oliviertassinari merged commit 96c4139 into mui:master Aug 18, 2024
17 checks passed
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 18, 2024 •
edited
Loading

I'm doing a first quick pass with this one, merged.

#3928 will be perfect to polish the angels.

@oliviertassinari oliviertassinari deleted the add-head branch August 18, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

@Janpot Janpot Janpot approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse website Related to the marketing pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @Janpot @bharatkashyap