[website][docs][cli] Make Core the default project #3868
Conversation
bharatkashyap
added
docs
bharatkashyap
requested review from
Janpot and
apedroferreira
and removed request for
Janpot
github-actions
bot
added
the
PR: out-of-date
| {secondaryLabel} | ||
| </Button> | ||
| ) : null} | ||
| <GithubStars /> |
There was a problem hiding this comment.
As there's another page with a Github star button, couldn't both pages use the same component?
There was a problem hiding this comment.
They are both using the same component - the GithubStars component inside landing-studio
There was a problem hiding this comment.
Ah nevermind I guess I misread the diff in this case.
| ); | ||
|
|
||
| // check that file exists or not in the directory | ||
| const gitignore = await fs.readFile(path.resolve(testDir, './.gitignore'), { |
There was a problem hiding this comment.
I guess you can also use fs.exists or fs.stat instead of readFile here (not sure which is better or the best way nowadays, would have to try it)
There was a problem hiding this comment.
Node.js deprecated fs.exists in favour of fs.access and fs.stat, both of which warn against using them to check for existence before attempting to read or write the file, for race condition worries: https://nodejs.org/api/fs.html#fsstatpath-options-callback
There was a problem hiding this comment.
Oh ok great I didn't know (wasn't sure like I said :D), thanks for clarifying!
Co-authored-by: Pedro Ferreira <[email protected]> Signed-off-by: Bharat Kashyap <[email protected]>
Co-authored-by: Pedro Ferreira <[email protected]> Signed-off-by: Bharat Kashyap <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
github-actions
bot
added
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
changed the title
https://deploy-preview-3868--mui-toolpad-docs.netlify.app/toolpad/
https://deploy-preview-3868--mui-toolpad-docs.netlify.app/toolpad/studio/