-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve docs and address some ahrefs reported 404s #3928
Conversation
@@ -4,7 +4,7 @@ title: Toolpad Overview | |||
|
|||
# Toolpad Core | |||
|
|||
<p class="description">A framework to build full-stack apps, fast. It can be used as a Next.js starter, or integrated within an existing React project to build dashboards and internal tools. </p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prakhargupta1 @bharatkashyap This title is reported as too long. We'll need a shorter, more descriptive one.
Also remove 'framework'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to: A set of full-stack components to build react dashboards.
@@ -14,6 +15,11 @@ import StudioIntro from '../../src/components/landing/StudioIntro'; | |||
export default function Home() { | |||
return ( | |||
<BrandingCssVarsProvider> | |||
<Head | |||
title="Toolpad Core: Open-source dashboard framework for React" | |||
description="Toolpad Core offers the components needed for your next admin panel and internal tools project." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prakhargupta1 This title/description was missing, might need better copy. Also may need a new twitter card image
Signed-off-by: Jan Potoms <[email protected]>
There is a 404 warning for https://mui.com/home coming from https://mui.com/toolpad/core/react-page-container/. Olivier's suggestion: For /home we can replace this with /inbox we already have a case for those in the docs. |
@@ -4,9 +4,9 @@ title: useNotifications | |||
components: NotificationsProvider | |||
--- | |||
|
|||
# Notifications | |||
# useNotifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep "Notifications" and instead change the title
property above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a suggestion to improve the DX, page h1 to be the same as sidenav title. We can choose between Notifications or useNotifications.
Signed-off-by: Jan Potoms <[email protected]>
Signed-off-by: Jan Potoms <[email protected]>
Signed-off-by: Jan Potoms <[email protected]>
Signed-off-by: Jan Potoms <[email protected]>
Address some ahrefs issues
TO DO