-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid loading python-ecdsa when using the cryptography backend #178
Conversation
The test failure is unrelated and documented here : #176 |
Thanks for this, I like it. I'm waiting on tlsfuzzer/python-ecdsa#205 to be merged, but in the meantime would you mind pinning |
I have another branch that I'm actively working on where I make the Travis tests a lot more straightforward, so this should hopefully not be an issue for very much longer, but for now the Travis configuration hands off to tox to run the actual tests. And tox "installs the current package", which seems to mean that it runs the equivalent of |
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 97.18% 90.87% -6.32%
==========================================
Files 14 14
Lines 1067 1063 -4
==========================================
- Hits 1037 966 -71
- Misses 30 97 +67
Continue to review full report at Codecov.
|
@blag I'm not sure what is going on with |
No worries, codecov gets confused sometimes. This looks good. Thank you for fixing the tests and dependency! |
Thanks @blag. Can we get a version bump so we can get this in Home Assistant release 0.114? |
Wow, you all really seem to take "release early, release often" as "release right now, release constantly". 😜 I'll bump the version and publish it to PyPI. Thank you all for Home Assistant! |
@bdraco Version 3.2.0 is now available on PyPI and GitHub. 😄 |
Thank you 🍾 |
In #117 dependency on
ecdsa
cryptography backend was removed, however it is still loaded even when not used. Sinceecdsa
has a load time performance penalty whengmpy2
is not installed, this can be a bit painful on embedded systems.We can avoid all this overhead and check to see if the key object hasattr
to_pem
instead since we onlycare of these if
ecdsa
has already been loaded by something else.