Remove pyca/cryptography backend's dependency on python-ecdsa #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
pyca/cryptography
backend was dependent onpython-ecdsa
to handle the conversion between DER encoded signatures and the raw signature encoding that JOSE uses.This fixes that, using the DSS encoding/decoding utilities provided in
pyca/cryptography
and adding simplified raw signature encoding and decoding directly.Also added in here are modifications to the tox and Travis CI configurations to remove
python-ecdsa
andpython-rsa
when testing thepyca/cryptography
backend in isolation. This is a workaround until we can determine how best to remove those dependencies when the "cryptography" extras is selected.NOTE: The
algorithms/test_RSA.py::test_cryptography_RSA_key_instance
test in the "compatibility" test runs will still fail. That is addressed separately in #116. The "base" test runs also still fail, as discussed in #114.