Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyca/cryptography backend's dependency on python-ecdsa #117

Merged
merged 8 commits into from
Dec 27, 2018

Conversation

mattsb42-aws
Copy link
Contributor

@mattsb42-aws mattsb42-aws commented Dec 25, 2018

Previously, the pyca/cryptography backend was dependent on python-ecdsa to handle the conversion between DER encoded signatures and the raw signature encoding that JOSE uses.

This fixes that, using the DSS encoding/decoding utilities provided in pyca/cryptography and adding simplified raw signature encoding and decoding directly.

Also added in here are modifications to the tox and Travis CI configurations to remove python-ecdsa and python-rsa when testing the pyca/cryptography backend in isolation. This is a workaround until we can determine how best to remove those dependencies when the "cryptography" extras is selected.

NOTE: The algorithms/test_RSA.py::test_cryptography_RSA_key_instance test in the "compatibility" test runs will still fail. That is addressed separately in #116. The "base" test runs also still fail, as discussed in #114.

@mpdavis
Copy link
Owner

mpdavis commented Dec 27, 2018

LGTM

@mpdavis mpdavis merged commit ff8a03b into mpdavis:backend-explicit-tests Dec 27, 2018
@mattsb42-aws mattsb42-aws deleted the no-ecdsa branch December 27, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants