-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hass-nabucasa to avoid the performance penalty loading ecdsa #38056
Bump hass-nabucasa to avoid the performance penalty loading ecdsa #38056
Conversation
I assume we need pre-built wheels to make this work? |
We do not use this libs because we use cryptography. The question is, why they there... |
It looks like the cryptography backend still uses ecdsa via
|
Seems better to fix this upstream. |
Yeah, cryptography is allready high optimize and running in C with openssl with is better optimize as |
Update chain |
Just the hass-nabucasa change left, and this can move forward. |
9a60a42
to
62ffe70
Compare
Proposed change
The
ecdsa
module which is used byjose
viacloud
does it calculationsin pure python. The latest
python-jose
release no longer loads ecdsaif
cryptography
is available.This shaved another second off of startup time.
On a basic install:
Home Assistant initialized in 7.93s
->Home Assistant initialized in 6.82s
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: