Skip to content

[Reproducer] Align MoRI-IO message format with P2pNcclConnector and vllm-router#4

Draft
simondanielsson wants to merge 26 commits into
fix/moriio-sane-defaultsfrom
reproducer/moriio-sane-defaults
Draft

[Reproducer] Align MoRI-IO message format with P2pNcclConnector and vllm-router#4
simondanielsson wants to merge 26 commits into
fix/moriio-sane-defaultsfrom
reproducer/moriio-sane-defaults

Conversation

@simondanielsson
Copy link
Copy Markdown
Collaborator

@simondanielsson simondanielsson commented Apr 10, 2026

This branch contains reproducers that validate that the MoRI-IO connector can be used in conjunction with vllm-router, after merging the following PRs:

Read through the README added in this RR to replicate the results.

See benchmark results here.

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@simondanielsson simondanielsson changed the title Reproducer/moriio sane defaults [Reproducer] moriio sane defaults Apr 10, 2026
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
@simondanielsson simondanielsson force-pushed the fix/moriio-sane-defaults branch from 057fced to 364441f Compare April 10, 2026 12:03
app.config["RESPONSE_TIMEOUT"] = 360000

app.run(host="0.0.0.0", port=10001)
app.run(host="0.0.0.0", port=_http_port)
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simplicity of the reproducer script we allow passing in the ports as env vars, to avoid relaunching the P/D instances

unzip \
wget \
&& rm -rf /var/lib/apt/lists/*

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required to make MoRI work with broadcom NICs

@simondanielsson simondanielsson changed the title [Reproducer] moriio sane defaults [Reproducer] Align MoRI-IO message format with P2pNcclConnector and vllm-router Apr 11, 2026
--name moriio-router \
--network host \
"${_ACTIVE_ROUTER_IMAGE}" \
vllm-router \
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant