[Fix] add streaming support in process_vllm_two_stage_request_discovered#139
Closed
simondanielsson wants to merge 1 commit into
Closed
Conversation
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
97b0748 to
f27a10d
Compare
This was referenced Apr 10, 2026
Draft
Contributor
Author
|
Closed in favor of this: #114 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
We might close this PR in favor of #114
Closes #113.
The service discovery path for vllm PD disaggregation does not support streaming, as opposed to the regular
process_vllm_two_stage_requestpath (without service discovery) which does support streaming.This PR adds support for response streaming also in the service discovery path. Without this, you cannot use the router with service discovery together with
vllm bench serve --backend vllmwhich requires that streaming works.Test Plan
Reproducer:
Test Result
Reproducer:
Essential Elements of an Effective PR Description Checklist