[Fix][MoRI] Add MoRI-IO connector support#138
Conversation
…eation for initial MoRI-IO support Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
9e1d84f to
5545b3f
Compare
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
| "do_remote_prefill": false, | ||
| "remote_engine_id": serde_json::Value::Null, | ||
| "remote_block_ids": serde_json::Value::Null, | ||
| "remote_host": serde_json::Value::Null, |
There was a problem hiding this comment.
remote_host and remote_port are not read by any prefill instance's connector, so it's safe to remove them
…oyments Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
0c1aeee to
1e66f5a
Compare
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-authored-by: Bugen Zhao <i@bugenzhao.com> Signed-off-by: Bugen Zhao <i@bugenzhao.com>
|
@BugenZhao Does this failing CI look like an unrelated issue to you as well? 🙏 |
Yes I think it's #154 aims to resolve. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 328e9ce50f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// MoRI-IO KV transfer | ||
| #[serde(rename = "moriio")] | ||
| #[value(name = "moriio")] | ||
| MoriIO, |
There was a problem hiding this comment.
Accept
moriio in Python kv_connector validation
Adding KvConnector::MoriIO here does not make it usable from the Python API, because Router::to_config still only accepts "nixl" and "mooncake" and returns ValidationFailed for any other value (src/lib.rs, kv_connector match). In environments configuring the router through Python bindings, kv_connector="moriio" now fails at startup even though the enum advertises support.
Useful? React with 👍 / 👎.
Purpose
Fixes #126 and vllm-project/vllm#38692.
This PR adds
--kv-connector moriiotype for running vllm-router with MoRI-IO KV connectortransfer_idin thekv_transfer_paramsin the MoRI-IO connector and toy proxy (this PR is part of vllm 0.18.0). This PR applies the same for update the vllm-router, and also adds the requiredremote_dp_sizefor performing remote handshakes inside the MoRI connector. This allows us to support the MoRI-IO KV connector in vllm-router.Important: This does not interfere with any other connectors functionality.
Basic usage
Dependencies
vllm bench servewith the vllm backend: feat: support stream response in the process_vllm_two_stage_request_discovered #114Order of merging should be (1) the vllm PR (2) this PR (3) the streaming PR
Test Plan
This PR can be used in conjunction with this vllm PR to run vllm w/ MoRI-IO KV connector and vllm-router.
Reproducer scripts can be found in this temporary branch: mpashkovskii/vllm#4
It includes
The tests include both basic smoke test (example request), vllm bench serve, and GSM8K using lm_eval (although the latter two require streaming support as added in the PR(s) mentioned above).
Test Result
See vllm-project/vllm#39565 for full performance and accuracy benchmarks. Below we show results from minimal smoke test reproducer.
2 node using DSR1
Basic smoke test (note random params):
Essential Elements of an Effective PR Description Checklist