Bug 1658349 - Allow using the quantity metric type outside of Gecko #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After #1200 I should probably drop the C# commit, but then it would have glean_parser create invalid metrics. |
Nah, it's fine to leave this in. No worries. |
Dexterp37
requested changes
Sep 7, 2020
brizental
force-pushed
the
1658349-quantity
branch
from
ad2f5d1
to
6354a8b
Compare
Dexterp37
approved these changes
Sep 7, 2020
badboy
requested changes
Sep 7, 2020
There was a problem hiding this comment.
This requires documentation updates here: https://mozilla.github.io/glean/book/user/metrics/quantity.html
Please also add a changelog entry.
brizental
force-pushed
the
1658349-quantity
branch
from
0313c59
to
b39ca7b
Compare
badboy
approved these changes
Sep 10, 2020
Co-authored-by: Jan-Erik Rediger <[email protected]>
brizental
force-pushed
the
1658349-quantity
branch
from
fcee843
to
c849b40
Compare
badboy
added a commit
to badboy/application-services
that referenced
this pull request
Sep 18, 2020
Glean changelog: * General * Allow using quantity metric type outside of Gecko ([mozilla#1198](mozilla/glean#1198)) * Update `glean_parser` to 1.28.5 * The `SUPERFLUOUS_NO_LINT` warning has been removed from the glinter. It likely did more harm than good, and makes it hard to make metrics.yaml files that pass across different versions of `glean_parser`. * Expired metrics will now produce a linter warning, `EXPIRED_METRIC`. * Expiry dates that are more than 730 days (~2 years) in the future will produce a linter warning, `EXPIRATION_DATE_TOO_FAR`. * Allow using the Quantity metric type outside of Gecko. * New parser configs `custom_is_expired` and `custom_validate_expires` added. These are both functions that take the expires value of the metric and return a bool. (See `Metric.is_expired` and `Metric.validate_expires`). These will allow FOG to provide custom validation for its version-based `expires` values. * Add a limit of 250 pending ping files. ([mozilla#1217](mozilla/glean#1217)). Note: This also gets rid of the 2 workarounds (removed code) in AppService thanks to upstream changes.
4 tasks
badboy
added a commit
to badboy/application-services
that referenced
this pull request
Sep 21, 2020
Glean changelog: * General * Allow using quantity metric type outside of Gecko ([mozilla#1198](mozilla/glean#1198)) * Update `glean_parser` to 1.28.5 * The `SUPERFLUOUS_NO_LINT` warning has been removed from the glinter. It likely did more harm than good, and makes it hard to make metrics.yaml files that pass across different versions of `glean_parser`. * Expired metrics will now produce a linter warning, `EXPIRED_METRIC`. * Expiry dates that are more than 730 days (~2 years) in the future will produce a linter warning, `EXPIRATION_DATE_TOO_FAR`. * Allow using the Quantity metric type outside of Gecko. * New parser configs `custom_is_expired` and `custom_validate_expires` added. These are both functions that take the expires value of the metric and return a bool. (See `Metric.is_expired` and `Metric.validate_expires`). These will allow FOG to provide custom validation for its version-based `expires` values. * Add a limit of 250 pending ping files. ([mozilla#1217](mozilla/glean#1217)). Note: This also gets rid of the 2 workarounds (removed code) in AppService thanks to upstream changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glean_parser PR: mozilla/glean_parser#225