Skip to content

Commit

Permalink
Upgrade Glean to v32.4.0
Browse files Browse the repository at this point in the history
Glean changelog:

* General
  * Allow using quantity metric type outside of Gecko ([mozilla#1198](mozilla/glean#1198))
  * Update `glean_parser` to 1.28.5
    * The `SUPERFLUOUS_NO_LINT` warning has been removed from the glinter. It likely did more harm than good, and makes it hard to make metrics.yaml files that pass across different versions of `glean_parser`.
    * Expired metrics will now produce a linter warning, `EXPIRED_METRIC`.
    * Expiry dates that are more than 730 days (~2 years) in the future will produce a linter warning, `EXPIRATION_DATE_TOO_FAR`.
    * Allow using the Quantity metric type outside of Gecko.
    * New parser configs `custom_is_expired` and `custom_validate_expires` added. These are both functions that take the expires value of the metric and return a bool. (See `Metric.is_expired` and `Metric.validate_expires`). These will allow FOG to provide custom validation for its version-based `expires` values.
  * Add a limit of 250 pending ping files. ([mozilla#1217](mozilla/glean#1217)).

Note: This also gets rid of the 2 workarounds (removed code) in
AppService thanks to upstream changes.
  • Loading branch information
badboy committed Sep 21, 2020
1 parent 7762c4b commit 5b3f4cf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 23 deletions.
2 changes: 1 addition & 1 deletion components/glean
Submodule glean updated 105 files
20 changes: 6 additions & 14 deletions components/logins/ios/Logins/Extensions/String+Free_Logins.swift
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,9 @@

import Foundation

/*
* NOTE: This is now provided by Glean.
* Because it's all compiled into a single libmegazord.a it doesn't matter which `destroy_string` we call,
* internally it defers to the same string implementation.
* Because Glean is added as a submodule it's easier to change this occurence than it it to change the one of Glean.
*/
/*
extension String {
public init(freeingRustString rustString: UnsafeMutablePointer<CChar>) {
defer { sync15_passwords_destroy_string(rustString) }
self.init(cString: rustString)
}
}
*/
extension String {
public init(freeingRustString rustString: UnsafeMutablePointer<CChar>) {
defer { sync15_passwords_destroy_string(rustString) }
self.init(cString: rustString)
}
}
8 changes: 0 additions & 8 deletions megazords/ios/MozillaAppServices.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,6 @@
FOUNDATION_EXPORT double MegazordClientVersionNumber;
FOUNDATION_EXPORT const unsigned char MegazordClientVersionString[];

/**
* FIXME: Glean has a `getGleanVersion` function that uses this constant.
* That function is not actually used (and the version wrong anyway).
* Because Glean is added as a submodule it's easier to change this occurence than it it to change the one of Glean,
* for now.
*/
static double GleanVersionNumber = 0.0;

#import "RustFxAFFI.h"
#import "RustPasswordAPI.h"
#import "RustLogFFI.h"
Expand Down

0 comments on commit 5b3f4cf

Please sign in to comment.