Upgrade Glean to v32.4.0 #3590
Merged
Upgrade Glean to v32.4.0 #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3590 +/- ##
==========================================
+ Coverage 76.77% 77.17% +0.40%
==========================================
Files 230 230
Lines 30928 30383 -545
==========================================
- Hits 23744 23449 -295
+ Misses 7184 6934 -250
Continue to review full report at Codecov.
|
🎉 thank you! |
badboy
changed the title
Glean changelog: * General * Allow using quantity metric type outside of Gecko ([mozilla#1198](mozilla/glean#1198)) * Update `glean_parser` to 1.28.5 * The `SUPERFLUOUS_NO_LINT` warning has been removed from the glinter. It likely did more harm than good, and makes it hard to make metrics.yaml files that pass across different versions of `glean_parser`. * Expired metrics will now produce a linter warning, `EXPIRED_METRIC`. * Expiry dates that are more than 730 days (~2 years) in the future will produce a linter warning, `EXPIRATION_DATE_TOO_FAR`. * Allow using the Quantity metric type outside of Gecko. * New parser configs `custom_is_expired` and `custom_validate_expires` added. These are both functions that take the expires value of the metric and return a bool. (See `Metric.is_expired` and `Metric.validate_expires`). These will allow FOG to provide custom validation for its version-based `expires` values. * Add a limit of 250 pending ping files. ([mozilla#1217](mozilla/glean#1217)). Note: This also gets rid of the 2 workarounds (removed code) in AppService thanks to upstream changes.
badboy
force-pushed
the
glean-upgrade-32.4.0
branch
from
319da93
to
5b3f4cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glean changelog:
glean_parserto 1.28.5SUPERFLUOUS_NO_LINTwarning has been removed from the glinter. It likely did more harm than good, and makes it hard to make metrics.yaml files that pass across different versions ofglean_parser.EXPIRED_METRIC.EXPIRATION_DATE_TOO_FAR.custom_is_expiredandcustom_validate_expiresadded. These are both functions that take the expires value of the metric and return a bool. (SeeMetric.is_expiredandMetric.validate_expires). These will allow FOG to provide custom validation for its version-basedexpiresvalues.Note: This also gets rid of the 2 workarounds (removed code) in
AppService thanks to upstream changes.
Pull Request checklist
automation/all_tests.shruns to completion and produces no failures[ci full]to the PR title.