Skip to content

Conversation

@eviljeff
Copy link
Member

@eviljeff eviljeff commented Nov 24, 2025

Fixes: https://mozilla-hub.atlassian.net/browse/AMOENG-2115

Description

Adds link to source builder, gated by the waffle defined in #24131

image

Context

Pretty useless right now until the main PR is merged, and the source builder service is up and running

Testing

  • Define and enable enable-source-builder waffle switch if you've not had it created via the migration in Call source builder API when source code is provided #24131
  • Navigate to a review page for an add-on that has one or more versions with source code uploaded
  • see link to Source Builder
  • (better delete the waffle switch again if you created it manually)

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff marked this pull request as ready for review November 24, 2025 14:09
@eviljeff eviljeff requested a review from willdurand November 24, 2025 14:09
Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc, thanks

@eviljeff eviljeff merged commit c6215e1 into mozilla:master Nov 27, 2025
89 of 90 checks passed
@ioanarusiczki
Copy link

@eviljeff I guess updating this here is fine, because I've noticed something after enabling the switch on stage.

On dev it seems to be working just fine meaning I am redirected to https://addon-builder-61bc7e6a6897.herokuapp.com/login after I click on Source Builder url.
On stage it reopens the same page instead, you can try with https://reviewers.addons.allizom.org/en-US/reviewers/review/2252834

I see while hovering over the url that dev has herokuapp.com but stage has reviewers.addons.allizom.org instead.
addon id , version id are present (as expected)

@eviljeff
Copy link
Member Author

I guess SOURCE_BUILDER_VIEWER_URL is only defined for addons-dev right now - I believe @willdurand added the env config for this?

@willdurand
Copy link
Member

I guess SOURCE_BUILDER_VIEWER_URL is only defined for addons-dev right now - I believe @willdurand added the env config for this?

Yes, that's correct. This is only enabled on -dev, and in fact, it'd be best not to turn the source builder switch on on stage.

@ioanarusiczki
Copy link

ok, switch off on stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants