Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/olympia/lib/settings_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1557,3 +1557,5 @@ def read_only_mode(env):
SWAGGER_SCHEMA_FILE = path('schema.yml')

SWAGGER_UI_ENABLED = env('SWAGGER_UI_ENABLED', default=False) or TARGET != 'production'

SOURCE_BUILDER_VIEWER_URL = env('SOURCE_BUILDER_VIEWER_URL', default=None)
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ <h5>Average Daily Users:</h5>
{% else %}
The developer has provided source code.
{% endif %}
{% if waffle.switch('enable-source-builder') %}
&nbsp;|&nbsp;
<a href="{{ settings.SOURCE_BUILDER_VIEWER_URL }}?addon_id={{ addon.pk }}&version_id={{ version.pk }}"
class="source-builder"
target="_blank" rel="noopener noreferrer">Source Builder</a>
{% endif %}
</div>
{% endif %}

Expand Down
31 changes: 30 additions & 1 deletion src/olympia/reviewers/tests/test_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -4195,7 +4195,7 @@ def test_assay_link(self):
== f'vscode://mozilla.assay/review/{self.addon.guid}/{self.addon.current_version.version}'
)

def test_download_sources_link(self):
def _setup_source(self):
version = self.addon.current_version
tdir = temp.gettempdir()
source_file = temp.NamedTemporaryFile(suffix='.zip', dir=tdir, mode='r+')
Expand All @@ -4204,6 +4204,8 @@ def test_download_sources_link(self):
version.source.save(os.path.basename(source_file.name), DjangoFile(source_file))
version.save()

def test_download_sources_link(self):
self._setup_source()
url = reverse('reviewers.review', args=[self.addon.pk])

# Admin user: able to download sources.
Expand All @@ -4227,6 +4229,33 @@ def test_download_sources_link(self):
assert response.status_code == 200
assert b'Download files' in response.content

@override_settings(SOURCE_BUILDER_VIEWER_URL='https://source.builder/')
@override_switch('enable-source-builder', active=True)
def test_source_builder_link(self):
self._setup_source()
url = reverse('reviewers.review', args=[self.addon.pk])

response = self.client.get(url)
assert response.status_code == 200
doc = pq(response.content)
builder_link = doc('#versions-history td.files .source-builder')
assert builder_link[0].text == 'Source Builder'
assert (
builder_link.attr['href']
== f'https://source.builder/?addon_id={self.addon.id}&version_id={self.addon.current_version.id}'
)

@override_settings(SOURCE_BUILDER_VIEWER_URL='https://source.builder/')
@override_switch('enable-source-builder', active=False)
def test_no_source_link_if_waffle_off(self):
self._setup_source()
url = reverse('reviewers.review', args=[self.addon.pk])

response = self.client.get(url)
assert response.status_code == 200
doc = pq(response.content)
assert not doc('#versions-history td.files .source-builder')

def test_translations(self):
self.addon.name = {
'de': None,
Expand Down