Call source builder API when source code is provided #24131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdurand
force-pushed
the
source-builder
branch
2 times, most recently
from
9d86455 to
93e51ab
Compare
willdurand
commented
Nov 17, 2025
willdurand
force-pushed
the
source-builder
branch
from
93e51ab to
58443a5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
willdurand
force-pushed
the
source-builder
branch
from
58443a5 to
8212e05
Compare
diox
reviewed
Nov 27, 2025
diox
approved these changes
Nov 27, 2025
willdurand
force-pushed
the
source-builder
branch
from
94d622c to
ab35fad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#15930
Now that we have mozilla/addons#15929 fixed, we don't need any special auth mechanism, we can reuse what we have already. Obviously, we'll want to use service accounts (see mozilla/addons#15944) but that is kinda orthogonal to this patch. We can probably already test the interaction between AMO and the source builder app on -dev (with or without a service account as long as we only enable this on -dev).