Use ament_export_targets to fix exporting dependencies#80
Merged
tylerjw merged 2 commits intomoveit:ros2from Jun 28, 2021
Merged
Use ament_export_targets to fix exporting dependencies#80tylerjw merged 2 commits intomoveit:ros2from
tylerjw merged 2 commits intomoveit:ros2from
Conversation
vatanaksoytezer
suggested changes
Jun 25, 2021
vatanaksoytezer
left a comment
vatanaksoytezer
left a comment
There was a problem hiding this comment.
This seems to cause compile problems in downstream repos. See vatanaksoytezer/moveit2#5 and the CI log in that PR.
Member
Author
Should be fixed with the last commit |
vatanaksoytezer
approved these changes
Jun 26, 2021
vatanaksoytezer
left a comment
vatanaksoytezer
left a comment
There was a problem hiding this comment.
Yep that fixes the issue, thanks!
This was referenced Jun 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, the dependencies will not be exported correctly, this's required for moveit/moveit2#514 to pass