Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refact file interface #313

Merged
merged 16 commits into from
Nov 11, 2021
Merged

Refact file interface #313

merged 16 commits into from
Nov 11, 2021

Conversation

wenxuwan
Copy link
Member

@wenxuwan wenxuwan commented Nov 8, 2021

What this PR does:

Add interface for file, and fix some known issues.#98, #301, #300

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Docment and Copy interface will be add later.

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #313 (28f51d6) into main (8c0d0f9) will increase coverage by 0.24%.
The diff coverage is 59.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   56.65%   56.90%   +0.24%     
==========================================
  Files          48       48              
  Lines        2058     2100      +42     
==========================================
+ Hits         1166     1195      +29     
- Misses        769      774       +5     
- Partials      123      131       +8     
Impacted Files Coverage Δ
pkg/runtime/runtime.go 51.94% <0.00%> (ø)
pkg/grpc/api.go 72.16% <60.41%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c0d0f9...28f51d6. Read the comment docs.

@seeflood
Copy link
Member

This a big pr that changes the File api definition. @zach030 @bokket Could you help review this PR?
After merging this PR ,we can then go ahead working on #299 #276

@wenxuwan wenxuwan merged commit a9ee251 into mosn:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants