Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: File API lacks nil checking #300

Closed
seeflood opened this issue Nov 2, 2021 · 0 comments
Closed

bug: File API lacks nil checking #300

seeflood opened this issue Nov 2, 2021 · 0 comments
Assignees
@wenxuwan
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@seeflood
Copy link
Member

seeflood commented Nov 2, 2021 •
edited
Loading

What would you like to be added:
According to feedback from @fengmk2 , he got a panic when testing the js-sdk:
image
Although this panic is recovered by mosn server, it's still a bug that we should avoid.
The stack in the above image is not consistent with Layotto's code in #258 branch,but I guess it is caused by:
image

Meanwhile,I found that many code of File API lacks nil checking,for example:
image

Why is this needed:
@seeflood seeflood added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 2, 2021
@seeflood seeflood added the bug Something isn't working label Nov 4, 2021
@wenxuwan wenxuwan mentioned this issue Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wenxuwan wenxuwan

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wenxuwan @seeflood