Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add hdfs support #276

Merged
merged 27 commits into from
Jan 7, 2022
Merged

feat:add hdfs support #276

merged 27 commits into from
Jan 7, 2022

Conversation

bokket
Copy link
Contributor

@bokket bokket commented Oct 22, 2021

Signed-off-by: bokket [email protected]

What this PR does:
add Hdfs oss support for Layotto file system interface.

Which issue(s) this PR fixes:

Fixes #236

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@mosn-community-bot
Copy link

Hi @bokket, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@seeflood
Copy link
Member

Thanks for your contribution!

@seeflood seeflood requested a review from wenxuwan October 22, 2021 15:38
Signed-off-by: bokket <[email protected]>
@bokket
Copy link
Contributor Author

bokket commented Oct 25, 2021

Hi, @seeflood .My go version is 1.16.3.But CI seems to be stuck in 1.15.15.May be this is problematic? I've already executed go fmt locally.

Signed-off-by: bokket <[email protected]>
components/file/hdfs/oss/oss.go Outdated Show resolved Hide resolved
components/file/hdfs/oss/oss.go Outdated Show resolved Hide resolved
Signed-off-by: bokket <[email protected]>
Signed-off-by: bokket <[email protected]>
@seeflood
Copy link
Member

@wenxuwan Hi,how is the review process going on ? Can we merge this PR?

@bokket bokket changed the title feat:add hdfs oss support feat:add hdfs support Oct 30, 2021
@seeflood seeflood mentioned this pull request Nov 10, 2021
@wenxuwan
Copy link
Member

@bokket hi man, can you fix the conflict? and adapt you implementation for the new file interface?

@bokket
Copy link
Contributor Author

bokket commented Nov 14, 2021

@bokket hi man, can you fix the conflict? and adapt you implementation for the new file interface?

Hi.I will fix it in next week.

Signed-off-by: bokket <[email protected]>
@seeflood
Copy link
Member

I modified the pipeline to test components and sdk packages in #367 .
Please check the hdfs ut failure :)
@bokket

@bokket
Copy link
Contributor Author

bokket commented Dec 17, 2021

I modified the pipeline to test components and sdk packages in #367 . Please check the hdfs ut failure :) @bokket

These changes do not seem to be any problem, but it is strange that CI failed when testing to hdfs....

Signed-off-by: bokket <[email protected]>
@seeflood
Copy link
Member

@bokket The CI pipeline didn't run tests for components package,so we didn't know the ut failure until I modified the pipeline configuration.
You can run your hdfs ut locally to check the failure.
Here's the error message I reproduced in my goland IDE:
image

@bokket
Copy link
Contributor Author

bokket commented Dec 17, 2021

image
then it may be action.yaml did not add the port to the configuration, I tried to add hdfs port above ut

Signed-off-by: bokket <[email protected]>
Signed-off-by: bokket <[email protected]>
Signed-off-by: bokket <[email protected]>
@mosn mosn deleted a comment from seeflood Jan 7, 2022
Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit be22e2f into mosn:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add components for file interface
3 participants