Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment to exported function/method/interface/variable #112

Closed
tianjipeng opened this issue Jul 3, 2021 · 12 comments
Closed

add comment to exported function/method/interface/variable #112

tianjipeng opened this issue Jul 3, 2021 · 12 comments
Assignees
Labels

Comments

@tianjipeng
Copy link
Member

What would you like to be added:
Add comment to exported function/method/interface/variable.

Why is this needed:
There are many exported function/method/interface/variable that have no comment, it would be helpful if have comment.

@seeflood
Copy link
Member

seeflood commented Jul 4, 2021

Thanks for your feedback!
Lack of comments makes developers' experience very bad :<
We will assign different tasks and ask the developers to add comments to their code.
By the way,which part of code currently annoys you the most? We can add comments to that part first

@seeflood
Copy link
Member

seeflood commented Jul 4, 2021

Considering that the workload of adding comments to all the modules is relatively large, we can split it into multiple tasks:

  • add comments to RPC related code. See Feature/add rpc anno #230
  • add comments to pubsub related code. feat: Add startup hooks #405
  • add comments to lock related code. assigned to @LXPWing
  • add comments to state API related code. assigned to @2019030007547
  • add comments to actuator related code . assigned to @Holdonbei
  • add comments to tcpdump related code
  • add comments to WASM related code . assigned to @LXPWing
  • add comments to flow-control related code
  • add comments to configuration API related code

@wudi-666272
Copy link

hi,Can you leave this task “add comments to RPC related code” to me to complete

@seeflood
Copy link
Member

seeflood commented Sep 20, 2021

hi,Can you leave this task “add comments to RPC related code” to me to complete

Cool!
Already assigned.Welcome to the Layotto Community and feel free to ask for help when u encounter problems.

@LXPWing
Copy link
Member

LXPWing commented Oct 11, 2021

Hi,I want to try the task 'add comments to lock related code'

@seeflood
Copy link
Member

@LXPWing Thanks for your passion!
I modified the tasks list above and the task 'add comments to lock related code' has been assigned to u.
Sorry to reply so late,I was 7*24 oncall this week and too busy to check the github notification :(

@seeflood seeflood added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 21, 2021
@LXPWing
Copy link
Member

LXPWing commented Dec 16, 2021

Recently learning WASM , I want to try the task 'add comments to WASM related code'

@seeflood
Copy link
Member

Recently learning WASM , I want to try the task 'add comments to WASM related code'

Cool ! assigned to u

@Xunzhuo
Copy link
Member

Xunzhuo commented Mar 6, 2023

/good-first-issue cancel
/help-wanted cancel

@Holdonbei
Copy link
Contributor

Holdonbei commented Mar 6, 2023 via email

@github-actions github-actions bot removed good first issue Good for newcomers help wanted Extra attention is needed labels Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This issue has been automatically marked as stale because it has not had recent activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue or help wanted) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 7, 2023
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue or help wanted. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants