Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment of wasm #370

Merged
merged 9 commits into from
Dec 20, 2021
Merged

add comment of wasm #370

merged 9 commits into from
Dec 20, 2021

Conversation

LXPWing
Copy link
Member

@LXPWing LXPWing commented Dec 19, 2021

What this PR does:
add comment of wasm #112

@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #370 (d491d3f) into main (3cf8915) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   58.03%   58.03%           
=======================================
  Files         106      106           
  Lines        5636     5636           
=======================================
  Hits         3271     3271           
  Misses       2030     2030           
  Partials      335      335           
Impacted Files Coverage Δ
pkg/wasm/abi.go 8.69% <ø> (ø)
pkg/wasm/config.go 48.93% <ø> (ø)
pkg/wasm/dispatch.go 0.00% <ø> (ø)
pkg/wasm/factory.go 24.48% <ø> (ø)
pkg/wasm/filter.go 0.00% <ø> (ø)
pkg/wasm/imports.go 65.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf8915...d491d3f. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Thanks for your contribution!
I think we can ignore the test coverage warning,since this PR doesn't change code.

@seeflood seeflood requested a review from ZLBer December 20, 2021 03:28
Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood seeflood merged commit 3816b8e into mosn:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants