Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add actuator comments #479

Merged
merged 2 commits into from
Apr 19, 2022
Merged

chore: add actuator comments #479

merged 2 commits into from
Apr 19, 2022

Conversation

Holdonbei
Copy link
Contributor

What this PR does:
add comments to actuator related code .
related: #112

@mosn-community-bot
Copy link

Hi @Holdonbei, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@seeflood
Copy link
Member

Thanks for your contribution!
To fix the CI error, please modify the title to "feature: xxxx" or "feat: xxx"
image

@Holdonbei Holdonbei changed the title Feature/add actuator comments Feature: add actuator comments Apr 16, 2022
@Holdonbei Holdonbei changed the title Feature: add actuator comments feature: add actuator comments Apr 16, 2022
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #479 (68b1928) into main (f46cc1f) will not change coverage.
The diff coverage is n/a.

❗ Current head 68b1928 differs from pull request most recent head fe4f4c8. Consider uploading reports for the commit fe4f4c8 to get more accurate results

@@           Coverage Diff           @@
##             main     #479   +/-   ##
=======================================
  Coverage   60.50%   60.50%           
=======================================
  Files         118      118           
  Lines        6357     6357           
=======================================
  Hits         3846     3846           
  Misses       2142     2142           
  Partials      369      369           
Impacted Files Coverage Δ
pkg/actuator/actuator.go 100.00% <ø> (ø)
pkg/actuator/health/endpoint.go 77.50% <ø> (ø)
pkg/actuator/health/indicator.go 64.70% <ø> (ø)
pkg/actuator/info/contributor.go 0.00% <ø> (ø)
pkg/actuator/info/endpoint.go 75.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46cc1f...fe4f4c8. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit d319a3f into mosn:main Apr 19, 2022
@seeflood seeflood changed the title feature: add actuator comments chore: add actuator comments Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants