Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add startup hooks #405

Merged
merged 24 commits into from
Apr 1, 2022
Merged

feat: Add startup hooks #405

merged 24 commits into from
Apr 1, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Mar 5, 2022

What this PR does:
Add startup hooks:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@mosn-community-bot mosn-community-bot bot added size/M and removed size/L labels Mar 5, 2022
@mosn-community-bot mosn-community-bot bot added size/L and removed size/M labels Mar 5, 2022
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #405 (f3ca2c2) into main (d74ff0e) will increase coverage by 0.25%.
The diff coverage is 81.81%.

❗ Current head f3ca2c2 differs from pull request most recent head 8467396. Consider uploading reports for the commit 8467396 to get more accurate results

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   60.24%   60.50%   +0.25%     
==========================================
  Files         117      118       +1     
  Lines        6268     6357      +89     
==========================================
+ Hits         3776     3846      +70     
- Misses       2130     2142      +12     
- Partials      362      369       +7     
Impacted Files Coverage Δ
pkg/grpc/default_api/api_pubsub.go 41.93% <ø> (ø)
pkg/grpc/default_api/api_state.go 86.48% <ø> (ø)
pkg/runtime/config.go 60.00% <ø> (ø)
pkg/runtime/options.go 40.35% <80.00%> (+8.43%) ⬆️
pkg/runtime/runtime.go 60.36% <80.00%> (+3.06%) ⬆️
components/custom/registry.go 84.00% <84.00%> (ø)
pkg/grpc/dapr/dapr_api.go 58.53% <100.00%> (ø)
pkg/grpc/default_api/api.go 85.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74ff0e...8467396. Read the comment docs.

zhenjunMa
zhenjunMa previously approved these changes Mar 28, 2022
@seeflood
Copy link
Member Author

seeflood commented Mar 28, 2022

todo:

Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood
Copy link
Member Author

seeflood commented Apr 1, 2022

Thank you all for your review !

@seeflood seeflood merged commit 31dda6a into mosn:main Apr 1, 2022
@seeflood seeflood deleted the add_hook branch April 1, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants