Replace deprecated CheckInherents with an equivalent ConsensusHook#3397
Replace deprecated CheckInherents with an equivalent ConsensusHook#3397
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
WASM runtime size check:Compared to target branchMoonbase runtime: 1992 KB (no changes) ✅ Moonbeam runtime: 2096 KB (-8 KB) ✅ Moonriver runtime: 2100 KB (-4 KB) ✅ Compared to latest release (runtime-3900)Moonbase runtime: 1992 KB (-368 KB compared to latest release) ✅ Moonbeam runtime: 2096 KB (-384 KB compared to latest release) ✅ Moonriver runtime: 2100 KB (-380 KB compared to latest release) ✅ |
Coverage Report@@ Coverage Diff @@
## master rq/remove-deprecated-check-inherents +/- ##
========================================================================
+ Coverage 74.46% 74.51% +0.05%
- Files 397 396 -1
- Lines 96013 95981 -32
========================================================================
+ Hits 71493 71519 +26
- Misses 24520 24462 -58
|
This reverts commit 9d5a2d9.
|
This chopsticks PR broke our chopsticks tests for the changes included in this PR. Looking into it |
What does it do?
Replaces deprecated
CheckInherentswith an equivalentConsensusHook. (cumulus changes: paritytech/cumulus#2300)Discussion in Polkadot-sdk: paritytech/polkadot-sdk#2841
CheckInherentswas removed in paritytech/polkadot-sdk#9732What important points should reviewers know?