Remove the deprecated CheckInherents logic#9732
Merged
Conversation
This removes the `CheckInherents` logic from `register_validate_block`, instead the `ConsensusHook` should be used to verify certain data. Besides that it also changes the how `validate_block` verifies the `ValidationData` passed by the collator. Instead of extracting the `ValidationData` before executing the block, the validation data is now checked as part of the pallet logic.
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
serban300
reviewed
Sep 15, 2025
cumulus/pallets/parachain-system/src/validate_block/implementation.rs
Outdated
Show resolved
Hide resolved
Member
Author
|
@serban300 applied your comments |
Member
Author
|
/cmd prdoc --audience runtime_dev --bump minor |
…time_dev --bump minor'
bkchr
commented
Sep 17, 2025
serban300
approved these changes
Sep 17, 2025
lexnv
approved these changes
Sep 17, 2025
RomarQ
reviewed
Sep 17, 2025
cumulus/pallets/parachain-system/src/validate_block/implementation.rs
Outdated
Show resolved
Hide resolved
Contributor
|
This can also be removed: |
…inherents' into bkchr-remove-check-inherents
RomarQ
approved these changes
Sep 17, 2025
skunert
approved these changes
Sep 17, 2025
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
This removes the `CheckInherents` logic from `register_validate_block`, instead the `ConsensusHook` should be used to verify certain data. Besides that it also changes the how `validate_block` verifies the `ValidationData` passed by the collator. Instead of extracting the `ValidationData` before executing the block, the validation data is now checked as part of the pallet logic. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
CheckInherentslogic fromregister_validate_block, instead theConsensusHookshould be used to verify certain data.Besides that it also changes the how
validate_blockverifies theValidationDatapassed by the collator. Instead of extracting theValidationDatabefore executing the block, the validation data is now checked as part of the pallet logic.