Skip to content

Remove deprecated code#3539

Merged
RomarQ merged 3 commits intomasterfrom
rq/remove-deprecated
Nov 4, 2025
Merged

Remove deprecated code#3539
RomarQ merged 3 commits intomasterfrom
rq/remove-deprecated

Conversation

@RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Nov 3, 2025

Removes code deprecated in #3397

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rq/remove-deprecated

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RomarQ RomarQ self-assigned this Nov 3, 2025
@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 1980 KB (-4 KB) ✅

Moonbeam runtime: 2108 KB (no changes) ✅

Moonriver runtime: 2108 KB (no changes) ✅

Compared to latest release (runtime-4000)

Moonbase runtime: 1980 KB (+208 KB compared to latest release) ⚠️

Moonbeam runtime: 2108 KB (+244 KB compared to latest release) ⚠️

Moonriver runtime: 2108 KB (+244 KB compared to latest release) ⚠️

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Coverage Report

@@                   Coverage Diff                   @@
##           master   rq/remove-deprecated     +/-   ##
=======================================================
  Coverage   74.71%                 74.71%   0.00%     
  Files         397                    397             
- Lines       96484                  96479      -5     
=======================================================
  Hits        72081                  72081             
- Misses      24403                  24398      -5     
Files Changed Coverage
/node/service/src/lib.rs 55.76% (+0.27%) 🔼

Coverage generated Mon Nov 3 20:39:56 UTC 2025

Copy link
Contributor

@manuelmauro manuelmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RomarQ RomarQ merged commit 2a4e54d into master Nov 4, 2025
72 of 73 checks passed
@RomarQ RomarQ deleted the rq/remove-deprecated branch November 4, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants