Girazoki xtokens fee with extrinsic#1007
Merged
girazoki merged 18 commits intomoonbeam-polkadot-v0.9.13from Dec 13, 2021
Merged
Girazoki xtokens fee with extrinsic#1007girazoki merged 18 commits intomoonbeam-polkadot-v0.9.13from
girazoki merged 18 commits intomoonbeam-polkadot-v0.9.13from
Conversation
…fee-with-extrinsic
girazoki
added
the
B7-runtimenoteworthy
…fee-with-extrinsic
…fee-with-extrinsic
…o girazoki-xtokens-fee-with-extrinsic
girazoki
added a commit
that referenced
this pull request
Dec 17, 2021
* change xtokens precompile to accept new extrinsic * Remove left over encoding file * Cleanup * Rust integration tests * MOdify typescript tests to try with_Fee extrinsics * Commit the compiled contract * Point to latest * Re-update cargo lock * Mimic upstream changes * Update lock * toml formatter * Fix test * Fix test * Adapt to distinct eth tx type
girazoki
added a commit
that referenced
this pull request
Dec 17, 2021
* Girazoki xtokens fee with extrinsic (#1007) * change xtokens precompile to accept new extrinsic * Remove left over encoding file * Cleanup * Rust integration tests * MOdify typescript tests to try with_Fee extrinsics * Commit the compiled contract * Point to latest * Re-update cargo lock * Mimic upstream changes * Update lock * toml formatter * Fix test * Fix test * Adapt to distinct eth tx type * Prettier and forgot record manual cost * used gas * typo * Fix precompile tests
tgmichel
added a commit
that referenced
this pull request
Dec 24, 2021
* v0.9.13 update * update utils to revert instead of error (using gasometer) * improve try_dispatch util * update assets-erc20 precompile set * update balances-erc20 precompile * update crowdloan-rewards precompile * update democracy precompile * update parachain-staking precompile * update relay-encoder precompile * update xcm-transactor precompile * update xtokens precompile + remove refactored file * update utils tests * update asset-erc20 precompile mock/test * update balances-erc20 precompile mock/test * update crowdloan-rewards precompile mock/test * update pallet-democracy precompile mock/test * update parachain-staking precompile mock/test * update relay-encoder precompile mock/test * update xcm-transactor precompile mock/test * update xtokens precompile mock/test * toml-sort * line length * `TxPoolRuntimeApi` version 2 * Ethereum typed transactions * PrecompilesType / Value for runtimes * Add pallet_utility PalletOrigin assoc type * Add pallet_scheduler OriginPrivilegeCmp assoc type * Update EthereumRuntimeRPCApi `call` and `create` * Handle typed transactions in `impl_self_contained_call` * Update precompiles `PrecompileResult` + `is_static` + `is_precompile` * Just match for input.len * fmt * Fix Erc20AssetsPrecompileSet * Update StorageProvider impl * Update service ConvertTransaction * Remove service deprecated fields * Add spawn task groups * Add genesis schema to `frontier-schema-cache-task` * More fixes :) * Update tests * fmt * Remove parachain_id cli arg usage * tests precompiles reverts * `call_max_size` test for runtimes * Filtered calls now return CallFiltered error * VersionedMultiLocation needs to be Boxed * Update xm-transactor tests * fmt * Update pallet-maintenance-mode tests * Update frontier pin * (ts test) update polkadotApi.tx.evm.call args * Update frontier pin * Add storage_schema to pallet-ethereum GenesisConfig * Include EthereumStorageSchema::V2 in map + update frontier-schema-cache-task * fmt * toml-sort * Update tests * Add `pallet-base-fee` * Use current base fee on precompile ts tests * Update frontier pin * Remove pallet ethereum configurable genesis schema * Add tests for each type of transaction (#1040) * Update `TransactionOptions` iface to 1559 fields * Update tests to pass full `context` instead `web3` * Include type and chainId in `createTransaction` * add describeDevMoonbeamAllEthTxTypes to relevant tests * Remove create blocks not needed Co-authored-by: tgmichel <telmo@purestake.com> * Impl `OnChargeEVMTransaction` in moonbase runtime * Fix eth txn fee handling for `verifyLatestBlockFees` tests * checker * Update `open-runtime-module-library` pin * Update dep pin * Update polkadot pin * usee struct literal syntax * Pin substrate democracy vote events * fmt * Remove unused import * Fix crowdloan ts test * add feature force-debug for all runtimes (#1053) * add feature force-debug for all runtimes * apply toml_sort * fix: AccountId20 must impl Debug (#1054) * Adds github token to generate runtime script (#1055) * Fix staking try runtime (attempt #2) (#1056) * Add missing imports * Make staking compile for try-runtime tests (#1014) * fix * fix lack of From impl compilation error Co-authored-by: Amar Singh <asinghchrony@protonmail.com> * Bake Moonbeam spec into the binary (#1063) * copy spec from moonbeam-networks * add bootnodes * 👩🍳 Bake it * Add CI workflow "Create client release ticket" (#1047) * Add CI workflow "Create client release ticket" * make the text impersonal * editorconfig * commit suggestions * Add CI workflow "Create runtime release ticket" (#1062) * Add CI workflow "Create runtime release ticket" * add substitutes step Co-authored-by: Alan Sapede <alan.sapede@gmail.com> Co-authored-by: Stephen Shelton <steve@brewcraft.org> Co-authored-by: Amar Singh <asinghchrony@protonmail.com> Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com> * Girazoki xtokens fee with extrinsic (#1007) * change xtokens precompile to accept new extrinsic * Remove left over encoding file * Cleanup * Rust integration tests * MOdify typescript tests to try with_Fee extrinsics * Commit the compiled contract * Point to latest * Re-update cargo lock * Mimic upstream changes * Update lock * toml formatter * Fix test * Fix test * Adapt to distinct eth tx type * Updates test setup for parachain tests * Updates polkadot-launch version * Naming convention * Update crowdloan-rewards pin * Re-introduce `parachain-id` cli arg * Upate nimbus pin * Update pallet democracy precompile tests * pin shiny new nimbus branch * fix Cargo.lock reversions. I wonder why that happened. * Bring manual seal hotifx into substrate hotfix branch * Fix tests * Update `is_precompile` fn * Update `open-runtime-module-library` pin * Update frontier pin * Follow up merge * FMT * Prettier * Adapt new precompiles to 0.9.13 * unused import after merge * New for precompileset * Fix errors in unitests * Fix unitests * Calls are unfiltered now * Update frontier pin * Update ts test `test-balance-transfer` with pending * Update ts test `test-contract-creation` with pending * Prettify * Update `test-pallet-maintenance-mode` * Fix substrate version * Fixes test setup Co-authored-by: nanocryk <6422796+nanocryk@users.noreply.github.com> Co-authored-by: Antoine Estienne <antoine@purestake.com> Co-authored-by: Éloïs <c@elo.tf> Co-authored-by: Alan Sapede <alan.sapede@gmail.com> Co-authored-by: Stephen Shelton <steve@brewcraft.org> Co-authored-by: Amar Singh <asinghchrony@protonmail.com> Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com> Co-authored-by: Crystalin <alan@purestake.com> Co-authored-by: Joshy Orndorff <admin@joshyorndorff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
This uses moonbeam-foundation/open-runtime-module-library#2, which added two new extrinsics to xtokens to allow specifying the fee aside the amount to be transferred.
This change has been accepted in Acala's upstream repo
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?