Skip to content

Comments

Girazoki xtokens fee with extrinsic to 0.9.12 (#1007)#1099

Merged
girazoki merged 5 commits intomasterfrom
girazoki-bring-fee-with-extrinsic-to-0.9.12
Dec 17, 2021
Merged

Girazoki xtokens fee with extrinsic to 0.9.12 (#1007)#1099
girazoki merged 5 commits intomasterfrom
girazoki-bring-fee-with-extrinsic-to-0.9.12

Conversation

@girazoki
Copy link
Collaborator

@girazoki girazoki commented Dec 17, 2021

What does it do?

Brings #1007 to 1100.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

* change xtokens precompile to accept new extrinsic

* Remove left over encoding file

* Cleanup

* Rust integration tests

* MOdify typescript tests to try with_Fee extrinsics

* Commit the compiled contract

* Point to latest

* Re-update cargo lock

* Mimic upstream changes

* Update lock

* toml formatter

* Fix test

* Fix test

* Adapt to distinct eth tx type
@girazoki girazoki added the B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes label Dec 17, 2021
@girazoki girazoki changed the title Girazoki xtokens fee with extrinsic (#1007) Girazoki xtokens fee with extrinsic to 0.9.12 (#1007) Dec 17, 2021
@girazoki girazoki added the A0-pleasereview Pull request needs code review. label Dec 17, 2021
@librelois librelois mentioned this pull request Dec 17, 2021
25 tasks
@girazoki girazoki merged commit 079a77b into master Dec 17, 2021
@girazoki girazoki deleted the girazoki-bring-fee-with-extrinsic-to-0.9.12 branch December 17, 2021 13:40
@crystalin crystalin added A8-mergeoncegreen Pull request is reviewed well. and removed A0-pleasereview Pull request needs code review. labels Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants