Conversation
nanocryk
approved these changes
Dec 17, 2021
Contributor
nanocryk
left a comment
nanocryk
left a comment
There was a problem hiding this comment.
Looks good to me. As said above I would still advise someone else take a look at the changes in precompiles (utils, impl of each precompile(set), etc) since i partially wrote those changes.
girazoki
reviewed
Dec 20, 2021
# Conflicts: # tests/tests/test-precompile/test-precompile-assets-erc20.ts
girazoki
approved these changes
Dec 22, 2021
crystalin
added
A8-mergeoncegreen
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
0.9.13.0.33.0+ new precompiles error handling.OnChargeEVMTransactionimpl.What important points reviewers should know?
OnChargeEVMTransactionimpl, where currently the block author is left un-tipped.pallet_base_fee::BaseFeeThresholdimpl on moonbase runtime a.k.a. what we consider an empty / ideal / full block.Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?