Don't link libGL, libGLU and libX11 at compile time#242
Closed
kekekeks wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for this. Closing as it will be merged with #241 |
mattleibow
added a commit
that referenced
this pull request
Jun 17, 2026
The "Update Release Notes" agentic workflow
(.github/workflows/update-release-notes.md, timeout-minutes: 15) timed out on
its first post-merge run. The cause was the per-PR "effort" badge: it ran one
network `git fetch refs/pull/N/head` per PR to recover pre-squash commit
detail. For the 4.148 release that is 162 serial fetches, each paying full
proxied-TLS setup (~4s) behind the workflow's Squid firewall — ~11 min plus an
unshallow, blowing the 15-min cap. On timeout `safe_outputs` is skipped, so no
PR is ever opened and the cold author-cache never warms: the cold start cannot
self-heal.
The effort value (commit count + working days) earned none of that cost: it is
not rendered in the notes and the model never surfaced it. Everything actually
shown — title, author, number, body, companion skia link — already comes from a
single local `git log`.
Changes:
* Remove the effort computation and its rendering entirely
(_get_pr_effort_from_git, compute_pr_effort, _fetch_skia_pr_effort,
add_pr_effort). This alone takes a cold full `--all` from a 15-min timeout
to ~35s.
* Keep the companion `skia: mono/skia#N` hint, parsed locally from the PR
body, and add the `mono/skia#N` shorthand that milestone bumps use.
* Resolve the companion link for submodule-bump PRs that don't spell it out,
purely locally. The bump and its target skia SHA are read from the
superproject tree (`git rev-parse <commit>:externals/skia` vs its parent);
the bumped skia commit's own subject ((#N) / "Merge pull request #N") is then
read from the submodule. The only network is one batched, blobless, shallow
`git fetch` of just the bumped SHAs; already-present commits are skipped, so
`--all` fetches each skia commit at most once (a handful per run, not 162).
For 4.148 this lifts companion-link coverage of skia-bumping PRs from 18 to 22
of 23. The single remaining gap is an anomalous backwards gitlink (PR #4081
resets the submodule to mono/skia's scaffold root, which has no PR); its real
companion, skia #242, is already linked via the forward bump. The other
historical misses are skia commits pushed directly to mono/skia with no PR at
all, so there is nothing to link.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
added a commit
that referenced
this pull request
Jul 3, 2026
Auto-apply milestone labels to the mono/skia sync PR too (#4329) Fixes: #4317 Context: #4327 (the mono/SkiaSharp side of the same fix) The skia-sync workflow opens a companion PR in mono/skia (push_skia in .github/scripts/skia-sync-push-prs.sh) alongside the mono/SkiaSharp PR, but only the parent PR was being labeled. #4327 fixed labeling for the parent; this applies the same taxonomy to the mono/skia PR so both stay in sync. * Every skia-sync PR now gets type/milestone-sync. * Milestone-number bumps additionally get type/milestone-bump. On the mono/skia side a "bump" is a merge that advances SK_MILESTONE in include/core/SkMilestone.h (the analog of scripts/VERSIONS.txt on the parent). * Renamed the shared flag SS_IS_MILESTONE_BUMP -> IS_MILESTONE_BUMP, since it now drives labels for both PRs, and applied labels on the create and update paths. Also created both labels in mono/skia (colors matching mono/SkiaSharp: bump #6f42c1, sync #a371f7) and backfilled every merged sync PR by inspecting the actual SK_MILESTONE change at each merge commit: * bump + sync (10): #122 (m116), #138 (m117), #139 (m118), #148 (m119), #171 (m132), #179 (m133), #184 (m147), #250 (m148), #253 (m150), #274 (m151) * sync only (5): #242 (m147), #255 (m150 Tizen backport), #259 (m150), #268 (m148), #278 (m151) Scope starts at m116 because no mono/skia PR set m115 (it was a direct push), mirroring the parent side; the 2016 m53 PRs (#15, #17) predate modern milestone tracking and were left out. The script is copied and run directly by the workflow, so no .lock.yml regeneration is needed (bash -n passes). Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be used with mono/skia#50