[skia-sync] Merge upstream chrome/m147 bug fixes#4081
Merged
Conversation
Picks up es-metadata.yml scaffold addition from mono/skia. Changes: - externals/skia: advance submodule to bf112f783f (adds es-metadata.yml) - cgmanifest.json: update mono/skia commitHash to bf112f783f No upstream C++ changes, no C API changes, no binding regeneration needed. Build: Linux x64 clean, 5504 tests passed (171 skipped - GPU hardware not available). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 4081PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 4081"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-4081/packages --name skiasharp-pr-4081More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-4081 |
Contributor
|
📖 Documentation Preview The documentation for this PR has been deployed and is available at: 🔗 View Staging Site This preview will be updated automatically when you push new commits to this PR. This comment is automatically updated by the documentation staging workflow. |
mattleibow
marked this pull request as ready for review
May 30, 2026 08:12
This was referenced Jun 9, 2026
This was referenced Jun 15, 2026
mattleibow
added a commit
that referenced
this pull request
Jun 17, 2026
The "Update Release Notes" agentic workflow
(.github/workflows/update-release-notes.md, timeout-minutes: 15) timed out on
its first post-merge run. The cause was the per-PR "effort" badge: it ran one
network `git fetch refs/pull/N/head` per PR to recover pre-squash commit
detail. For the 4.148 release that is 162 serial fetches, each paying full
proxied-TLS setup (~4s) behind the workflow's Squid firewall — ~11 min plus an
unshallow, blowing the 15-min cap. On timeout `safe_outputs` is skipped, so no
PR is ever opened and the cold author-cache never warms: the cold start cannot
self-heal.
The effort value (commit count + working days) earned none of that cost: it is
not rendered in the notes and the model never surfaced it. Everything actually
shown — title, author, number, body, companion skia link — already comes from a
single local `git log`.
Changes:
* Remove the effort computation and its rendering entirely
(_get_pr_effort_from_git, compute_pr_effort, _fetch_skia_pr_effort,
add_pr_effort). This alone takes a cold full `--all` from a 15-min timeout
to ~35s.
* Keep the companion `skia: mono/skia#N` hint, parsed locally from the PR
body, and add the `mono/skia#N` shorthand that milestone bumps use.
* Resolve the companion link for submodule-bump PRs that don't spell it out,
purely locally. The bump and its target skia SHA are read from the
superproject tree (`git rev-parse <commit>:externals/skia` vs its parent);
the bumped skia commit's own subject ((#N) / "Merge pull request #N") is then
read from the submodule. The only network is one batched, blobless, shallow
`git fetch` of just the bumped SHAs; already-present commits are skipped, so
`--all` fetches each skia commit at most once (a handful per run, not 162).
For 4.148 this lifts companion-link coverage of skia-bumping PRs from 18 to 22
of 23. The single remaining gap is an anomalous backwards gitlink (PR #4081
resets the submodule to mono/skia's scaffold root, which has no PR); its real
companion, skia #242, is already linked via the forward bump. The other
historical misses are skia commits pushed directly to mono/skia with no PR at
all, so there is nothing to link.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
added
the
type/milestone-sync
mattleibow
added
the
partner/agentic-workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated upstream bug-fix sync for m147.
mono/SkiaSharp PR Summary — Skia m147 sync
Overview
Same-milestone sync (m147 → m147). Picks up an internal mono/skia commit (es-metadata.yml)
that was on the
skiasharpbranch but not yet referenced by SkiaSharp's submodule pointer.Changes
Submodule Update
externals/skia:7a2d809b3c→bf112f783fes-metadata.yml(CI/DevOps scaffold metadata)cgmanifest.json
commitHashfor mono/skia:8044793ff0...→bf112f783f...chrome_milestone: 147 (unchanged)upstream_merge_commit:dcbd374c13...(unchanged — no new upstream commits)Breaking Changes
None. This is a metadata-only sync with no C++ or API changes.
Version Changes
Binding Regeneration
No changes — C API signatures unchanged. Bindings not regenerated.
Build & Test Results
Skipped tests are GPU/Vulkan/D3D12 tests that self-skip when hardware is unavailable (expected on CI Linux).
Items Needing Human Attention
None. Routine metadata sync.
Created by skia-upstream-sync.