Auto-apply milestone labels to the mono/skia sync PR too (#4317)#4329
Merged
Conversation
The skia-sync workflow opens a companion PR in mono/skia (push_skia) in addition to the mono/SkiaSharp PR. Apply the same labeling there: - Every skia-sync PR gets type/milestone-sync. - Milestone-number bumps (those that change SK_MILESTONE in include/core/SkMilestone.h) additionally get type/milestone-bump. Rename SS_IS_MILESTONE_BUMP -> IS_MILESTONE_BUMP since the flag now drives labels for both the mono/skia and mono/SkiaSharp PRs. Labels are applied on both the create and update paths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 4329PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 4329"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-4329/packages --name skiasharp-pr-4329More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-4329 |
Contributor
|
📖 Documentation Preview The documentation for this PR has been deployed and is available at: 🔗 View Staging Site This preview will be updated automatically when you push new commits to this PR. This comment is automatically updated by the documentation staging workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4327 (which handled the
mono/SkiaSharpPR). Also part of #4317.The skia-sync workflow opens a companion PR in
mono/skia(thepush_skia()function in.github/scripts/skia-sync-push-prs.sh), in addition to themono/SkiaSharpPR. This applies the same labeling there.Workflow change
type/milestone-sync.type/milestone-bump. On themono/skiaside, "bump" means the merge advancesSK_MILESTONEininclude/core/SkMilestone.h(the analog ofscripts/VERSIONS.txton the parent).SS_IS_MILESTONE_BUMP→IS_MILESTONE_BUMP, since it now drives labels for both PRs.Backfill (mono/skia)
Classified every merged sync PR by whether it changed
SK_MILESTONE:bumpsyncFinal counts: 10
type/milestone-bump, 15type/milestone-sync.Notes:
mono/skiaPR set m115 (it was a direct push toskiasharp), so scope starts at m116 — mirroring the parent side.m53PRs (Improved Build #15, SKRect constructor with width/height broken #17) predate modern milestone tracking and were intentionally left out.bash -npasses; script is run directly by the workflow (no.lock.ymlregeneration needed).Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com