Skip to content

Auto-apply milestone labels to the mono/skia sync PR too (#4317)#4329

Merged
mattleibow merged 1 commit into
mainfrom
mattleibow-milestone-bump-label-workflow
Jul 3, 2026
Merged

Auto-apply milestone labels to the mono/skia sync PR too (#4317)#4329
mattleibow merged 1 commit into
mainfrom
mattleibow-milestone-bump-label-workflow

Conversation

@mattleibow

Copy link
Copy Markdown
Contributor

Follow-up to #4327 (which handled the mono/SkiaSharp PR). Also part of #4317.

The skia-sync workflow opens a companion PR in mono/skia (the push_skia() function in .github/scripts/skia-sync-push-prs.sh), in addition to the mono/SkiaSharp PR. This applies the same labeling there.

Workflow change

  • Every skia-sync PR (both repos) gets type/milestone-sync.
  • Milestone-number bumps additionally get type/milestone-bump. On the mono/skia side, "bump" means the merge advances SK_MILESTONE in include/core/SkMilestone.h (the analog of scripts/VERSIONS.txt on the parent).
  • Renamed the shared flag SS_IS_MILESTONE_BUMPIS_MILESTONE_BUMP, since it now drives labels for both PRs.
  • Labels applied on both the create and update paths.

Created both labels in mono/skia (colors matching mono/SkiaSharp: bump #6f42c1, sync #a371f7).

Backfill (mono/skia)

Classified every merged sync PR by whether it changed SK_MILESTONE:

Kind PRs bump sync
Bumps #122(m116), #138(m117), #139(m118), #148(m119), #171(m132), #179(m133), #184(m147), #250(m148), #253(m150), #274(m151) ✅ (10)
Re-syncs / backport #242(m147), #255(m150 Tizen backport), #259(m150), #268(m148), #278(m151)

Final counts: 10 type/milestone-bump, 15 type/milestone-sync.

Notes:

  • No mono/skia PR set m115 (it was a direct push to skiasharp), so scope starts at m116 — mirroring the parent side.
  • The ancient 2016 m53 PRs (Improved Build #15, SKRect constructor with width/height broken #17) predate modern milestone tracking and were intentionally left out.
  • bash -n passes; script is run directly by the workflow (no .lock.yml regeneration needed).

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

The skia-sync workflow opens a companion PR in mono/skia (push_skia) in
addition to the mono/SkiaSharp PR. Apply the same labeling there:

- Every skia-sync PR gets type/milestone-sync.
- Milestone-number bumps (those that change SK_MILESTONE in
  include/core/SkMilestone.h) additionally get type/milestone-bump.

Rename SS_IS_MILESTONE_BUMP -> IS_MILESTONE_BUMP since the flag now drives
labels for both the mono/skia and mono/SkiaSharp PRs. Labels are applied on
both the create and update paths.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

📦 Try the packages from this PR

Warning

Do not run these scripts without first reviewing the code in this PR.

Step 1 — Download the packages

bash / macOS / Linux:

curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 4329

PowerShell / Windows:

iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 4329"

Step 2 — Add the local NuGet source

dotnet nuget add source ~/.skiasharp/hives/pr-4329/packages --name skiasharp-pr-4329
More options
Option Description
--successful-only / -SuccessfulOnly Only use successful builds
--force / -Force Overwrite previously downloaded packages
--list / -List List available artifacts without downloading
--build-id ID / -BuildId ID Download from a specific build

Or download manually from Azure Pipelines — look for the nuget artifact on the build for this PR.

Remove the source when you're done:

dotnet nuget remove source skiasharp-pr-4329

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

📖 Documentation Preview

The documentation for this PR has been deployed and is available at:

🔗 View Staging Site
🔗 View Staging Docs
🔗 View Staging Gallery (Blazor)
🔗 View Staging Gallery (Uno Platform)
🔗 View Staging SkiaFiddle

This preview will be updated automatically when you push new commits to this PR.


This comment is automatically updated by the documentation staging workflow.

@mattleibow
mattleibow merged commit 2fe1989 into main Jul 3, 2026
5 checks passed
@mattleibow
mattleibow deleted the mattleibow-milestone-bump-label-workflow branch July 3, 2026 17:23
@mattleibow mattleibow added this to the 4.151.0-preview.2 milestone Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant