feat(NODE-6389): add support for timeoutMS in StateMachine.execute() #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Warren James <[email protected]>
aditi-khare-mongoDB
changed the title
Co-authored-by: Warren James <[email protected]>
baileympearson
added
the
Primary Review
baileympearson
requested changes
Sep 30, 2024
test/integration/client-side-operations-timeout/client_side_operations_timeout.unit.test.ts
Outdated
Show resolved
Hide resolved
baileympearson
force-pushed
the
NODE-6090
branch
from
17a2fde
to
7a12914
Compare
baileympearson
requested changes
Oct 2, 2024
test/integration/client-side-operations-timeout/client_side_operations_timeout.unit.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-operations-timeout/client_side_operations_timeout.unit.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-operations-timeout/client_side_operations_timeout.unit.test.ts
Show resolved
Hide resolved
| ): Promise<Array<DataKey>> { | ||
| const { db: dbName, collection: collectionName } = | ||
| MongoDBCollectionNamespace.fromString(keyVaultNamespace); | ||
|
|
||
| return client | ||
| .db(dbName) | ||
| .collection<DataKey>(collectionName, { readConcern: { level: 'majority' } }) | ||
| .find(deserialize(filter)) | ||
| .find(deserialize(filter), { |
There was a problem hiding this comment.
Lots of red in CI caused by this - timeoutMode can only be specified if timeoutMS is specified too. Otherwise cursors throw an error.
Also - lint is failing
There was a problem hiding this comment.
Yep, changed it!
baileympearson
approved these changes
Oct 7, 2024
baileympearson
added a commit
that referenced
this pull request
Oct 10, 2024
…4243) Co-authored-by: Warren James <[email protected]> Co-authored-by: Neal Beeken <[email protected]> Co-authored-by: Bailey Pearson <[email protected]>
baileympearson
added a commit
that referenced
this pull request
Oct 10, 2024
…4243) Co-authored-by: Warren James <[email protected]> Co-authored-by: Neal Beeken <[email protected]> Co-authored-by: Bailey Pearson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StateMachine.executeand commands run against amongocryptdserver respect atimeoutMS.What is changing?
StateMachine.executemethod respectstimeoutMSfor the following operations:listCollectionsmongocryptdcommands now use remaining timeoutMS is used, and maxTimeMS is not appended to the command (ServerDescription.iscryptdfield is used to determind server type)Is there new documentation needed for these changes?
No
What is the motivation for this change?
CSOT
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript