feat(NODE-6312): add error transformation for server timeouts #4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
W-A-James
added
the
Primary Review
W-A-James
requested changes
Aug 8, 2024
tom-selander
added
Primary Review
nbbeeken
force-pushed
the
NODE-5687-csot-error-transformations
branch
from
4caa93a
to
728ab9e
Compare
tom-selander
added
Primary Review
W-A-James
requested changes
Aug 9, 2024
tom-selander
added
Primary Review
aditi-khare-mongoDB
requested changes
Aug 12, 2024
|
Bookkeeping: I'm taking over Warren's review while he's OOO. |
aditi-khare-mongoDB
approved these changes
Aug 12, 2024
nbbeeken
added a commit
that referenced
this pull request
Aug 13, 2024
nbbeeken
added a commit
that referenced
this pull request
Aug 20, 2024
nbbeeken
added a commit
that referenced
this pull request
Aug 21, 2024
nbbeeken
added a commit
that referenced
this pull request
Sep 12, 2024
nbbeeken
added a commit
that referenced
this pull request
Sep 25, 2024
nbbeeken
added a commit
that referenced
this pull request
Sep 27, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 1, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 1, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
Not for this PR. General CSOT documentation should cover the cases where a timeout error is encountered
What is the motivation for this change?
When CSOT is enabled the goal is to provide a consistent mechanism for timing out operations. Ususally a client side timeout should expire before a server is able to, but depending on the variance in RTT calculation it is possible for the maxTimeMS setting that is sent to the server to be shorter than what remains on the client side. In this case, if we get a server timeout we want to throw the same error that would normally occur in CSOT circumstances.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript