Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove empty skipped context blocks #4238

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

W-A-James
Copy link
Contributor

Description

What is changing?

Remove empty context blocks that unintentionally skipped tests that should have been running

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Test coverage

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken merged commit 3ed4a14 into NODE-6090 Sep 12, 2024
1 check was pending
@nbbeeken nbbeeken deleted the remove-unused-context-blocks branch September 12, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants