[LG-5649] feat(chat-layout): add SideNavItem subcomponent#3273
Merged
stephl3 merged 7 commits intoLG-5439/chat-layoutfrom Oct 31, 2025
Merged
[LG-5649] feat(chat-layout): add SideNavItem subcomponent#3273stephl3 merged 7 commits intoLG-5439/chat-layoutfrom
stephl3 merged 7 commits intoLG-5439/chat-layoutfrom
Conversation
stephl3
requested review from
adamrasheed and
shaneeza
and removed request for
a team
|
stephl3
force-pushed
the
steph/chat-layout-sidenav-item
branch
from
4bd9d26 to
979e102
Compare
Contributor
|
Size Change: 0 B Total Size: 1.63 MB ℹ️ View Unchanged
|
shaneeza
approved these changes
Oct 31, 2025
| expect(onClick).toHaveBeenCalledTimes(1); | ||
| }); | ||
|
|
||
| test('applies className prop', () => { |
Collaborator
There was a problem hiding this comment.
Do we need to test that the className prop is applied?
Collaborator
Author
There was a problem hiding this comment.
yes this is to ensure className is properly passed through to the root element
| // Layout | ||
| position: relative; | ||
| width: 100%; | ||
| min-height: 32px; |
Collaborator
There was a problem hiding this comment.
nit: Should this be stored in a var?
| <ChatSideNav.Content>{/* Your side nav content */}</ChatSideNav.Content> | ||
| </ChatSideNav> | ||
| <ChatMain>{/* Main chat content here */}</ChatMain> | ||
| <ChatSideNav>{/* Side nav subcomponents */}</ChatSideNav> |
Collaborator
There was a problem hiding this comment.
Why don't you want to show the sub-components here?
Collaborator
Author
There was a problem hiding this comment.
I wanted to highlight the props that this example showcase. Including the ChatSideNav subcomponents seemed like it would create too much noise and make it difficult to discern what is really being shown for this example
stephl3
force-pushed
the
steph/chat-layout-sidenav-item
branch
from
082c275 to
180c7ba
Compare
adamrasheed
approved these changes
Oct 31, 2025
stephl3
force-pushed
the
steph/chat-layout-sidenav-item
branch
from
541c83f to
7496879
Compare
Base automatically changed from
steph/chat-layout-sidenav
to
LG-5439/chat-layout
October 31, 2025 19:23
stephl3
force-pushed
the
steph/chat-layout-sidenav-item
branch
from
7496879 to
3421cc6
Compare
Contributor
|
Coverage after merging steph/chat-layout-sidenav-item into LG-5439/chat-layout will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
stephl3
added a commit
that referenced
this pull request
Nov 4, 2025
* chore(chat-layout): add LG palette dep * feat(chat-layout): implement ChatSideNavItem subcomponent * test(chat-layout): update stories * docs(chat-layout): README * fix(chat-layout): add missing polymorphic dep * fix(chat-layout): ChatSideNavItem default is div * style(chat-layout): use constant for side nav item height
stephl3
added a commit
that referenced
this pull request
Nov 7, 2025
* chore(chat-layout): add LG palette dep * feat(chat-layout): implement ChatSideNavItem subcomponent * test(chat-layout): update stories * docs(chat-layout): README * fix(chat-layout): add missing polymorphic dep * fix(chat-layout): ChatSideNavItem default is div * style(chat-layout): use constant for side nav item height
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
* feat(chat-layout): new @lg-chat/chat-layout package with ChatLayout and ChatLayoutContext (#3251) * [LG-5645] feat(chat-layout): implement ChatMain component (#3252) * feat(chat-layout): implement ChatMain component * refactor(chat-layout): remove PropsWithChildren * [LG-5646] feat(chat-layout): implement ChatSideNav component with Header and Content subcomponents (#3271) * chore(chat-layout): add deps for ChatSideNav * feat(chat-layout): implement ChatSideNav and subcomponents * test(chat-layout): update stories * docs(chat-layout): README * fix(chat-layout): apply focus styles on :focus-visible * refactor(chat-layout): PR feedback * refactor(chat-layout): ChatSideNav only renders header and content * [LG-5649] feat(chat-layout): add SideNavItem subcomponent (#3273) * chore(chat-layout): add LG palette dep * feat(chat-layout): implement ChatSideNavItem subcomponent * test(chat-layout): update stories * docs(chat-layout): README * fix(chat-layout): add missing polymorphic dep * fix(chat-layout): ChatSideNavItem default is div * style(chat-layout): use constant for side nav item height * [LG-5650] feat(chat-layout): add hover expand and collapse functionality (#3278) * feat(chat-layout): add header to ChatSideNavContent * fix(input-bar): rm redundant z-index and increase disclaimer text spacing * chore(input-bar): changeset * chore(chat-layout): rm icon-button dependency * feat(chat-layout): enhance ChatLayout with side nav hover state and transition effects * test(chat-layout): update stories * docs(chat-layout): README * refactor(input-bar): revert gap changes * refactor(chat-layout): expose shouldRenderExpanded from context and fix overflow * fix(chat-layout): peer dep and init changeset
TheSonOfThomp
added a commit
that referenced
this pull request
Nov 7, 2025
commit 5cf8c9b Merge: 75bd398 616cfb0 Author: Adam Thompson <adam.thompson@mongodb.com> Date: Fri Nov 7 15:40:20 2025 -0500 Merge branch 'main' into at/wizard-integration commit 616cfb0 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri Nov 7 18:49:16 2025 +0000 Version Packages (#3288) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit dca8419 Author: Nima Taheri <nima.taheri@mongodb.com> Date: Fri Nov 7 09:04:10 2025 -0800 LG-5588 more chart customization points (#3274) * feat: more chart customization points * docs: add changelog * feat: apply review feedbacks * feat: move common x/y axis properties into a separate file * fix: lint errors * fix: correct props dependency * fixup! fix: lint errors * feat: process review feedback * feat: apply Stephen's feedback * types: export bar-hover-behavior type * more PR review feedback * fix export issue commit 8976ab2 Author: Stephen Lee <stephen.lee@mongodb.com> Date: Fri Nov 7 07:39:33 2025 -0800 [LG-5439] feat: ChatLayout integration branch (#3289) * feat(chat-layout): new @lg-chat/chat-layout package with ChatLayout and ChatLayoutContext (#3251) * [LG-5645] feat(chat-layout): implement ChatMain component (#3252) * feat(chat-layout): implement ChatMain component * refactor(chat-layout): remove PropsWithChildren * [LG-5646] feat(chat-layout): implement ChatSideNav component with Header and Content subcomponents (#3271) * chore(chat-layout): add deps for ChatSideNav * feat(chat-layout): implement ChatSideNav and subcomponents * test(chat-layout): update stories * docs(chat-layout): README * fix(chat-layout): apply focus styles on :focus-visible * refactor(chat-layout): PR feedback * refactor(chat-layout): ChatSideNav only renders header and content * [LG-5649] feat(chat-layout): add SideNavItem subcomponent (#3273) * chore(chat-layout): add LG palette dep * feat(chat-layout): implement ChatSideNavItem subcomponent * test(chat-layout): update stories * docs(chat-layout): README * fix(chat-layout): add missing polymorphic dep * fix(chat-layout): ChatSideNavItem default is div * style(chat-layout): use constant for side nav item height * [LG-5650] feat(chat-layout): add hover expand and collapse functionality (#3278) * feat(chat-layout): add header to ChatSideNavContent * fix(input-bar): rm redundant z-index and increase disclaimer text spacing * chore(input-bar): changeset * chore(chat-layout): rm icon-button dependency * feat(chat-layout): enhance ChatLayout with side nav hover state and transition effects * test(chat-layout): update stories * docs(chat-layout): README * refactor(input-bar): revert gap changes * refactor(chat-layout): expose shouldRenderExpanded from context and fix overflow * fix(chat-layout): peer dep and init changeset commit 68b59a0 Author: Stephen Lee <stephen.lee@mongodb.com> Date: Thu Nov 6 20:18:38 2025 -0800 [LG-5687] fix(message-prompts): update border color (#3282) * style(message-prompts): update border-color * test(message-prompts): fix darkmode propagation * chore(message-prompts): changeset commit eb4ff15 Author: Stephen Lee <stephen.lee@mongodb.com> Date: Thu Nov 6 16:29:28 2025 -0800 refactor(feature-walls): darkMode propagation (#3287) * refactor(feature-walls): darkMode propagation * fix(feature-walls): drop unused imports commit 5008087 Author: Stephen Lee <stephen.lee@mongodb.com> Date: Thu Nov 6 15:33:37 2025 -0800 [LG-5684] fix(rich-links): update colors for RichLinkBadge component (#3283) * refactor(rich-links): refactor darkmode propagation and update some colors * test(rich-links): enable darkmode in rich-links stories * chore: changesets commit 1d63f1f Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Nov 6 19:39:48 2025 +0000 Version Packages (#3276) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 6494d15 Author: Brooke Scarlett Yalof <brooke.yalof@mongodb.com> Date: Thu Nov 6 12:17:17 2025 -0500 LG-5656: Remove support for refEl property (#3270) * remove support for refEl property * Update clean-news-lay.md commit af60a2d Author: Stephen Lee <stephen.lee@mongodb.com> Date: Thu Nov 6 07:58:22 2025 -0800 [LG-5664] feat(title-bar): add compact variant support (#3275) * refactor(title-bar): reorg file structure and export Align * refactor(title-bar): styles and install lg chat provider peer dep * feat(title-bar): compact variant * test(title-bar): update stories * docs(title-bar): readme * chore(title-bar): changeset * chore(title-bar): copilot feedback * feat(chat-window): enable compact TitleBar in ChatWindow * fix: chat builds commit 45fb29a Author: Adam Rasheed <adam.rasheed@mongodb.com> Date: Wed Nov 5 09:33:54 2025 -0800 [LG-5681] chore: Update PeerDependencies (#3279) * [LG-5681] chore: Update PeerDependencies * cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Adds
ChatSideNav.SideNavItemas a new compound subcomponent to display individual chat list items in the side navigation. The component supports active state styling, href-based navigation, and proper accessibility attributes. This enables developers to build chat navigation lists with active state indication and proper ARIA semantics.🎟️ Jira ticket: LG-5649
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
activeprop on items to verify:aria-current="page"attributearia-current="false"attributehrefprop render as anchor elementspnpm test chat/chat-layout/src/ChatSideNav/ChatSideNavItem/ChatSideNavItem.spec.tsx