-
Notifications
You must be signed in to change notification settings - Fork 72
refactor(vertical-stepper): move vertical stepper package from private to leafygreen-ui #3165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* wip * wip, transitions * image * break out step icon component * tabindex * line color * fix story * status to state * padding * style cleanup * style updates * consts * add tests * README * changeset * types and tests * cleanup * cleanup * lint * cleanup again * some feedback * update icon styles * inert and tabindex * use descedants * remove extra div * update package.json * pass isCompleted to StepIcon * cleanup * feedback
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix lg-private packages naming * Changeset
* LG-4395: vertical stepper design QA * LG-4395: feature walls design QA * Changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* VerticalStepper takes actions prop instead of primaryButtonProps and secondaryButtonProps * ActivationSteps uses updated VerticalStepper API * Changeset * Address feedback
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update Section styling and add optional renderInCard prop * FeatureOverview renders in card, handles children container, and removes custom storybook decorator * Templates always renders in card and export type Template * UseCases always renders in card * ActivationSteps type updates and remove storybook decorator * Export types for ActivationStep, Template, and UseCase * Changeset * LG-4413: vertical stepper always renders description and media (#195) * VerticalStepper always renders description and media * Changeset * Cleanup
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update vertical stepper button layout on smaller breakpoints * Fix resizing in AccordionPanel * Fix resizing in ExpandableGrid * Feedback * height is always available
* Version Packages * Version next @lg-private/vertical-stepper and update changelogs --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Stephen Lee <[email protected]>
* bump other packages * major popover updates * bump provider * bump global provider * bump cli * rm popoverZIndex * Create forty-days-rest.md * Delete .eslintignore * update lg to latest major * Removes prop-types, and bump LG packages * lint * Update .eslintrc.js * update storybook @lg-tools/storybook-utils * lint
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* pnpm import * Delete yarn.lock * workflows * yarn -> pnpm docs * workspace:^ * add missing global packages * @storybook/test * story ts fixes * Adds missing peers * rm lg.json * bump base lg * fix product icon builds * fix sb * bump peer deps * rm pnpm/action-setup@v4 * Revert "rm pnpm/action-setup@v4" This reverts commit 14198eb258e958ddaa0e480fee17cfddec5ce6fd. * Update pnpm-lock.yaml * apk * apk all * wget * restore pnpm * specific pnpm action * workspace * lint fix * tools @ latest * minor lint errors * tools build dev deps * typescript * tsconfig * package exports * ts fixes * Create rollup.config.mjs * lint * checkout main src * ts fixes * lint * isolated async tests * Update CloudNav.analytics.spec.tsx * skip mongonav tests * feature walls tests * Create rollup.config.mjs * lint fix * Update pr.yml * Update release.yml * cache/restore * chromatic + pnpm * update cache restore paths * cache save path * addon 0.5.2-next.0 * addon 0.5.2-next.2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR moves the vertical stepper component from the private @lg-private/vertical-stepper package to the public @leafygreen-ui/vertical-stepper package. This refactoring makes the component publicly available in the main LeafyGreen UI library while maintaining all existing functionality.
- Updates package scope from private to public
- Adds package to global documentation and TypeScript configuration
- Preserves all component functionality and API structure
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/vertical-stepper/tsconfig.json | TypeScript configuration for the new package location |
| packages/vertical-stepper/src/index.ts | Main entry point exporting component interfaces |
| packages/vertical-stepper/src/context/* | Context providers for stepper state management |
| packages/vertical-stepper/src/constants.ts | Component identifiers and test IDs |
| packages/vertical-stepper/src/VerticalStepper/* | Main stepper component implementation |
| packages/vertical-stepper/src/VerticalStep/* | Individual step component implementation |
| packages/vertical-stepper/src/VerticalStepActions/* | Actions component for step buttons |
| packages/vertical-stepper/src/StepIcon/* | Step indicator icon component |
| packages/vertical-stepper/package.json | Package configuration with updated scope |
| packages/vertical-stepper/README.md | Component documentation |
| packages/vertical-stepper/CHANGELOG.md | Version history including deprecated package reference |
| README.md | Added entry to main documentation table |
| .changeset/mighty-actors-tie.md | Release notes for the package migration |
270e5dd to
2ff9292
Compare
2ff9292 to
87eb202
Compare
|
Size Change: 0 B Total Size: 1.6 MB ℹ️ View Unchanged
|
Moves
@lg-private/vertical-stepperto@leafygreen-ui/vertical-stepper🎟️ Jira ticket: LG-5578
✅ Checklist