Skip to content

PD-406: Add ui-colors.less file #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bruugey merged 4 commits into from
Oct 10, 2019
Merged

PD-406: Add ui-colors.less file #169

bruugey merged 4 commits into from
Oct 10, 2019

Conversation

@bruugey
Copy link
Collaborator

@bruugey bruugey commented Oct 8, 2019 •
edited
Loading

✍️ Proposed changes

  • Palette package now includes palette.less file
  • Added file_loader module (so that palette.less is included in dist)

🎟 Jira ticket: PD-406

🛠 Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have run yarn changeset and documented my changes

DesignerDave
DesignerDave suggested changes Oct 8, 2019
View reviewed changes
package.json Outdated
]
},
"dependencies": {
"file-loader": "^4.2.0"
Copy link
Contributor

@DesignerDave DesignerDave Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PeerDependencies

Copy link
Collaborator Author

@bruugey bruugey Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/palette/src/uiColors.less Outdated
@@ -0,0 +1,35 @@
/* LeafyGreen Color Palette */
Copy link
Contributor

@DesignerDave DesignerDave Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is unnecessary.

Copy link
Collaborator Author

@bruugey bruugey Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

DesignerDave
DesignerDave approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@DesignerDave DesignerDave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruugey bruugey changed the title PD-406: Add uiColors.less file PD-406: Add ui-colors.less file Oct 8, 2019
@bruugey bruugey merged commit a0fdc57 into master Oct 10, 2019
@bruugey bruugey deleted the PD-406 branch October 10, 2019 15:49
bruugey added a commit that referenced this pull request Aug 9, 2023
@bruugey
PD-406: Add ui-colors.less file (#169)
425b93a 
* add uiColors.less

* passing tests

* semantics

* fix docs
stephl3 pushed a commit that referenced this pull request Sep 29, 2025
@github-actions
Version Packages (#169)
0d49273 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Sep 30, 2025
@stephl3 @shaneeza
@github-actions @TheSonOfThomp
refactor(vertical-stepper): move vertical stepper package from privat…
7b87c56 
…e to leafygreen-ui (#3165)

* LG-4333: VerticalStepper (#163)

* wip

* wip, transitions

* image

* break out step icon component

* tabindex

* line color

* fix story

* status to state

* padding

* style cleanup

* style updates

* consts

* add tests

* README

* changeset

* types and tests

* cleanup

* cleanup

* lint

* cleanup again

* some feedback

* update icon styles

* inert and tabindex

* use descedants

* remove extra div

* update package.json

* pass isCompleted to StepIcon

* cleanup

* feedback

* Version Packages (#169)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix naming of lg-private packages (#183)

* Fix lg-private packages naming

* Changeset

* LG-4395: feature walls major release (#186)

* LG-4395: vertical stepper design QA

* LG-4395: feature walls design QA

* Changeset

* Version Packages (#184)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Use actions slot prop for vertical stepper and activation steps (#191)

* VerticalStepper takes actions prop instead of primaryButtonProps and secondaryButtonProps

* ActivationSteps uses updated VerticalStepper API

* Changeset

* Address feedback

* Version Packages (#190)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* LG-4412: all sections render in card UI  (#194)

* Update Section styling and add optional renderInCard prop

* FeatureOverview renders in card, handles children container, and removes custom storybook decorator

* Templates always renders in card and export type Template

* UseCases always renders in card

* ActivationSteps type updates and remove storybook decorator

* Export types for ActivationStep, Template, and UseCase

* Changeset

* LG-4413: vertical stepper always renders description and media (#195)

* VerticalStepper always renders description and media

* Changeset

* Cleanup

* Version Packages (#197)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* LG-4670: feature walls component resizing (#294)

* Update vertical stepper button layout on smaller breakpoints

* Fix resizing in AccordionPanel

* Fix resizing in ExpandableGrid

* Feedback

* height is always available

* Version Packages (#292)

* Version Packages

* Version next @lg-private/vertical-stepper and update changelogs

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Stephen Lee <stephen.lee@mongodb.com>

* Updates Popover/Menu/Tooltip to TopLayer LG-4746 (#337)

* bump other packages

* major popover updates

* bump provider

* bump global provider

* bump cli

* rm popoverZIndex

* Create forty-days-rest.md

* Delete .eslintignore

* update lg to latest major

* Removes prop-types, and bump LG packages

* lint

* Update .eslintrc.js

* update storybook @lg-tools/storybook-utils

* lint

* Version Packages (#343)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* PNPM + Storybook 8 (private) (#426)

* pnpm import

* Delete yarn.lock

* workflows

* yarn -> pnpm docs

* workspace:^

* add missing global packages

* @storybook/test

* story ts fixes

* Adds missing peers

* rm lg.json

* bump base lg

* fix product icon builds

* fix sb

* bump peer deps

* rm  pnpm/action-setup@v4

* Revert "rm  pnpm/action-setup@v4"

This reverts commit 14198eb258e958ddaa0e480fee17cfddec5ce6fd.

* Update pnpm-lock.yaml

* apk

* apk all

* wget

* restore pnpm

* specific pnpm action

* workspace

* lint fix

* tools @ latest

* minor lint errors

* tools build dev deps

* typescript

* tsconfig

* package exports

* ts fixes

* Create rollup.config.mjs

* lint

* checkout main src

* ts fixes

* lint

* isolated async tests

* Update CloudNav.analytics.spec.tsx

* skip mongonav tests

* feature walls tests

* Create rollup.config.mjs

* lint fix

* Update pr.yml

* Update release.yml

* cache/restore

* chromatic + pnpm

* update cache restore paths

* cache save path

* addon 0.5.2-next.0

* addon 0.5.2-next.2

* chore(vertical-stepper): move from @lg-private to @leafygreen-ui scope

* chore(vertical-stepper): disable snapshot of LiveExample story

---------

Co-authored-by: Shaneeza <shaneeza.ali@mongodb.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adam Thompson <2414030+TheSonOfThomp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DesignerDave DesignerDave DesignerDave approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bruugey @DesignerDave