Update protos to pass function schedule in definition, not create request #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
commented
Oct 5, 2024
|
|
||
| // When the function is a "grouped" one, this records the # of tasks we want | ||
| // to schedule in tandem. | ||
| uint32 _experimental_group_size = 19; |
There was a problem hiding this comment.
Just moved this to keep the fields in order
mwaskom
force-pushed
the
michael/function-schedule-protos
branch
from
e43484c
to
65c6a2c
Compare
2 tasks
aksh-at
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing the schedule in the Function definition will allow us to make schedule updates atomic with app redeployments.
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.