Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protos to pass function schedule in definition, not create request #2328

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Update protos to pass function schedule in definition, not create request #2328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions modal_proto/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,6 +1078,9 @@ message Function {
optional string _experimental_proxy_ip = 70;

bool runtime_perf_record = 71; // For internal debugging use only.

Schedule schedule = 72;

}

message FunctionBindParamsRequest {
Expand Down Expand Up @@ -1140,7 +1143,7 @@ message FunctionCallPutDataRequest {
message FunctionCreateRequest {
Function function = 1;
string app_id = 2 [ (modal.options.audit_target_attr) = true ];
Schedule schedule = 6;
Schedule schedule = 6; // Deprecated: now passed in the Function definition
string existing_function_id = 7;
// This flag tells the server to avoid doing updates in FunctionCreate that should now
// be done in AppPublish. Provides a smoother migration onto atomic deployments with 0.64,
Expand Down Expand Up @@ -1191,15 +1194,18 @@ message FunctionData {
string use_function_id = 16; // used for methods
string use_method_name = 17; // used for methods

// When the function is a "grouped" one, this records the # of tasks we want
// to schedule in tandem.
uint32 _experimental_group_size = 19;

message RankedFunction {
uint32 rank = 1;
Function function = 2;
}
repeated RankedFunction ranked_functions = 18;

// When the function is a "grouped" one, this records the # of tasks we want
// to schedule in tandem.
uint32 _experimental_group_size = 19;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moved this to keep the fields in order


Schedule schedule = 20;

}

message FunctionExtended {
Expand Down
Loading