Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send schedule configuration in function definition, not request #2329

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Oct 6, 2024

This PR moves the schedule configuration into the Function definition; previously it was send as an additional field in the FunctionCreateRequest. Storing it in the definition allows us to make schedule updates atomically with the rest of function deployment.

Depends on #2328

Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

  • Fixed a bug where app rollbacks would not restart a schedule that had been removed in an intervening deployment.

@mwaskom mwaskom force-pushed the michael/send-schedule-in-function-definition branch from eb7fd60 to 1c86b0c Compare October 6, 2024 14:14
@mwaskom mwaskom merged commit 12388fb into main Oct 15, 2024
22 checks passed
@mwaskom mwaskom deleted the michael/send-schedule-in-function-definition branch October 15, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants