Repository navigation
feat!: change root package.json type to module - #6078
Merged
Merged
Conversation
mark-wiemer
force-pushed
the
root-package-type-module
branch
from
June 17, 2026 03:06
b79b5cf to
f6be57c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6078 +/- ##
==========================================
+ Coverage 78.83% 82.25% +3.41%
==========================================
Files 63 61 -2
Lines 4546 4564 +18
Branches 989 958 -31
==========================================
+ Hits 3584 3754 +170
+ Misses 962 810 -152 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
3 tasks done
mark-wiemer
commented
Jun 17, 2026
mark-wiemer
commented
Jun 17, 2026
mark-wiemer
commented
Jun 17, 2026
mark-wiemer
commented
Jun 17, 2026
mark-wiemer
commented
Jun 17, 2026
mark-wiemer
commented
Jun 17, 2026
mark-wiemer
commented
Jun 17, 2026
mark-wiemer
commented
Jun 17, 2026
mark-wiemer
commented
Jun 17, 2026
mark-wiemer
commented
Jun 17, 2026
mark-wiemer
commented
Jun 18, 2026
mark-wiemer
commented
Jun 18, 2026
mark-wiemer
marked this pull request as ready for review
June 18, 2026 03:03
3 tasks done
This was referenced Jul 28, 2026
This was referenced Aug 27, 2026
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Checklist
status: accepting prsOverview
My version of #6034, rebased to reduce merge conflicts and respect Josh's fork
"type": "module"so Mocha is now an ESM-first package (users can stillrequire('mocha'))jsfiles tocjsandmjsfiles tojsoptions.mjsto CJS (options.cjs) and some related files back to CJS due torewiremockusage and low ROI for implementing (risky!) replacement. Turns outoptions.spec.mjswasn't running in main (glob pattern) and when we made it run as ESM, it failed miserably!unitfolder, adding 1 test file (all tests pass)