Repository navigation
feat!: change root package.json type to module - #6034
JoshuaKGoldberg wants to merge 4 commits into
Conversation
|
Build failures seem to just be codecov/codecov-action#1876. |
|
Tests are passing on my Windows machine, Node 20.19.0, with the patched #6040 (ref mark-wiemer@08f921b), no unusual output aside from expected EBADENGINE when installing |
That bug is old and about random failures, which matches #6036 . I've created a new bug for consistent failures today: #6042 . |
|
Test failed on my Windows machine with Node v22.12.0: I'm going to pause my review now given this is in draft state and you're probably aware of some of these issues :) Happy to continue running Windows- or Linux-specific checks as needed, of course :) thanks for leading this one! |
mark-wiemer
left a comment
There was a problem hiding this comment.
Partial review given draft state, matches what I want though! Mostly! ;)
|
Ha yeah, I figured I'd come back to this after the Codecov issues were done. |
|
See also my PR: #6078 |
|
Closing out in favor of Mark's in-progress PR. |
PR Checklist
status: accepting prsOverview
At long last:
package.json'stypeis switched from"commonjs"to"module"The only "backwards" change here is
lib/cli/options.mjs->lib/cli/options.cjs. It's used inrequiremocktests and we haven't migrated to a mocker that supports ESM yet.💖