Repository navigation
chore: convert node-flags and run-option-metadata to ESM - #6447
Open
mostafaNazari702 wants to merge 3 commits into
Open
mostafaNazari702 wants to merge 3 commits into
mostafaNazari702 wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
lib/cli/files to ESM #5967status: accepting prsOverview
Convert the Node flag handling and the run option metadata to ESM. #6078 moved both back to CommonJS together with the options loader because the options tests mock that loader's dependencies the CommonJS way.
Since #6124 the options loader does not not load either of them anymore so that reason is gone. Also fixes the file name in a comment on the CLI docs page.
This touches two of the same import lines as #6445 so whichever one merges second needs a quick rebase.