Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf from 2.27.1 to 3.1.0 #2185

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 23, 2022

Bumps protobuf from 2.27.1 to 3.1.0.

Changelog

Sourced from protobuf's changelog.

Changelog

Changelog after version 3.0.0 lives in https://github.com/stepancheg/rust-protobuf/blob/master/CHANGELOG.md.

[3.0.0] - 2022-05-01

  • New stable version released.

[3.0.0-alpha.14] - 2022-05-01

  • JSON support is moved into a separate crate protobuf-json-mapping
  • Generated code for well known types is more similar to regular protobuf now (well known type modules are now placed as is in well_known_types module instead of being flattened).
  • file_descriptor_proto() function is private now in generated code. Descriptor can be obtained by calling file_descriptor().proto().
  • file_descriptor() now returns &'static FileDescriptor
  • Hide UnknownValues from public API (keep UnknownFields)

[3.0.0-alpha.13] - 2022-05-01

  • More efficient reflective operations
  • Fewer internals exposed from public API (e.g. ProtobufType is no longer public)

[3.0.0-alpha.12] - 2022-04-30

[3.0.0-alpha.11] - 2022-04-29

  • all fields are public now in generated messages
  • protobuf-support crate added. This crate contains utilities shared by other protobuf crates. This crate has no public API.

[3.0.0-alpha.10] - 2022-04-11

  • remove expose_oneof codegen option (it is on by default for a long time)
  • remove unused serde-related options from rustproto.proto
  • in generated code, enum variant names are converted to camel case
  • generate SpecialFields field in messages instead of a pair (unknown_fields, cached_size)
  • reflection operations like nested_messages now return iterator instead of Vec
  • replace fn Enum::values() with const Enum::VALUES
  • remove EnumFull::enum_descriptor(), does not provide much value over enum_descriptor_static
  • rename EnumFull::enum_descriptor_static -> enum_descriptor
  • fix EnumFull::descriptor for enums with allow_alias
  • rename MessageDescriptor::enums to nested_enums
  • rename MessageDescriptor::descriptor_static to descriptor
  • add EnumDescriptor::enclosing_message()
  • Message now requires PartialEq

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jun 23, 2022
@dependabot dependabot bot requested a review from a team June 23, 2022 03:40
@remoun remoun removed the request for review from a team June 23, 2022 04:12
@remoun
Copy link
Contributor

remoun commented Jun 23, 2022

We currently use protoc-grpcio (in util/build/grpc/Cargo.toml) to generate the Rust code, but there's no new version to match. I filed mtp401/protoc-grpcio#41 to track this.

I tried switching to protobuf-codegen (published from the same repo as protobuf), and discovered that their v3 changes the generated code significantly: stepancheg/rust-protobuf#521
That's not necessarily a dealbreaker, but it would result in a big change touching a lot of files, which will require more care, and would make cherry-picking to and from release branches that much harder.

@jcape
Copy link
Contributor

jcape commented Jun 23, 2022

My own recommendation is that, if there's a bunch of churn to make this go we should just switch to prost.

@dependabot dependabot bot force-pushed the dependabot/cargo/protobuf-3.1.0 branch from 90bb68a to 43e1ab8 Compare June 23, 2022 21:10
Bumps [protobuf](https://github.com/stepancheg/rust-protobuf) from 2.27.1 to 3.1.0.
- [Release notes](https://github.com/stepancheg/rust-protobuf/releases)
- [Changelog](https://github.com/stepancheg/rust-protobuf/blob/master/CHANGELOG-before-3.md)
- [Commits](stepancheg/rust-protobuf@v2.27.1...v3.1.0)

---
updated-dependencies:
- dependency-name: protobuf
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/protobuf-3.1.0 branch from 43e1ab8 to 814d968 Compare June 23, 2022 22:57
@remoun
Copy link
Contributor

remoun commented Jun 24, 2022

Closing in favor of #2198

@dependabot ignore this major version

@remoun remoun closed this Jun 24, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 24, 2022

OK, I won't notify you about version 3.x.x again, unless you re-open this PR or update to a 3.x.x release yourself.

@dependabot dependabot bot deleted the dependabot/cargo/protobuf-3.1.0 branch June 24, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants