Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from protobuf to prost #2198

Open
remoun opened this issue Jun 24, 2022 · 1 comment
Open

Migrate from protobuf to prost #2198

remoun opened this issue Jun 24, 2022 · 1 comment
Labels
protobufs Changes to protobuf APIs rust-update Area: rust updates tech-debt Technical debt payment

Comments

@remoun
Copy link
Contributor

remoun commented Jun 24, 2022

protobuf v3 changes the API significantly (stepancheg/rust-protobuf#518, stepancheg/rust-protobuf#521), so updating to the latest version would involve a lot of changes.

Since we have to use prost in enclaves (because protobuf does not support no_std), we might as well switch everything to prost.

@remoun remoun added rust-update Area: rust updates tech-debt Technical debt payment protobufs Changes to protobuf APIs labels Jun 24, 2022
@remoun remoun moved this to Todo in Blockchain Core Jun 24, 2022
@remoun remoun self-assigned this Jul 6, 2022
@remoun remoun moved this from Todo to In Progress in Blockchain Core Jul 7, 2022
@remoun
Copy link
Contributor Author

remoun commented Jul 15, 2022

I started hacking on this, but I don't have the bandwidth to see it through. WIP at https://github.com/mobilecoinfoundation/mobilecoin/tree/replace-protobuf

I'm thinking we'll work on this in a feature branch, accepting that it won't build until we've finished migrating all the protobuf references, then PR that into main.

@remoun remoun removed their assignment Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protobufs Changes to protobuf APIs rust-update Area: rust updates tech-debt Technical debt payment
Projects
Status: In Progress
Development

No branches or pull requests

1 participant