Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change generated code for version 3 release #521

Closed
2 of 4 tasks
Tracked by #518
stepancheg opened this issue Aug 12, 2020 · 3 comments
Closed
2 of 4 tasks
Tracked by #518

Change generated code for version 3 release #521

stepancheg opened this issue Aug 12, 2020 · 3 comments
Labels
rust-protobuf-v3 Issued to be fixed to release version 3

Comments

@stepancheg
Copy link
Owner

stepancheg commented Aug 12, 2020

  • Remove get_ prefix from functions as API guide suggests
  • Make all fields public
  • All singular fields should have getters (including singular proto3 fields)
  • Only oneof fields should have set_xxx and has_xxx methods
@stepancheg stepancheg added the rust-protobuf-v3 Issued to be fixed to release version 3 label Aug 12, 2020
@stepancheg stepancheg mentioned this issue Aug 12, 2020
12 tasks
@chanced
Copy link

chanced commented Apr 1, 2022

First off, thank you for your work on this project. It is by no means a small undertaking!

Would you mind exposing/generating all of the compiler related protobuf files? A lot of enums are not currently available, such as Name, IdempotencyLevel, NamePart, JsType and so on.

I'm working on a port of protoc-gen-star to rust here and it'd be really helpful if they were all available on this crate. I initially started with prost but it doesn't support unknown fields which I'll need for extension parsing.

I could generate them myself but it looks like you've modified the output somewhat? I could be wrong there.

Thanks again!

@stepancheg
Copy link
Owner Author

These types are present in rust-protobuf v3 (which is not release yet).

In rust-protobuf v2 probably code just need to be regenerated, but releasing v3 is my priority now.

@chanced
Copy link

chanced commented Apr 4, 2022

@stepancheg ugh, I'm sorry! I did a search across the repo and couldn't find them. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust-protobuf-v3 Issued to be fixed to release version 3
Projects
None yet
Development

No branches or pull requests

2 participants