KeyControl: make 'Unlock, reset to linear pitch' always reset pitch_adjust#4758
Closed
ronso0 wants to merge 1 commit into
Closed
KeyControl: make 'Unlock, reset to linear pitch' always reset pitch_adjust#4758ronso0 wants to merge 1 commit into
pitch_adjust#4758ronso0 wants to merge 1 commit into
Conversation
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
Bot
added
the
stale
github-actions
Bot
removed
the
stale
Member
Author
|
Rebasing this onto |
ronso0
force-pushed
the
keylock-fix-simple2
branch
from
aad059f to
7cf6866
Compare
ronso0
force-pushed
the
keylock-fix-simple2
branch
from
7cf6866 to
601c6a1
Compare
ronso0
changed the title
pitch_adjust
Member
Author
|
Closing this in favor of #4710 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up for #4756
"unlock, reset to linear pitch" changes
pitchTweakRatiothough doesn't apply it aspitch_adjust, thus there's an abrupt pitch change when touching thepitch_adjustknob afterwards.Also, I don't remember why we decided to make the unlock behaviour depend on the keylock mode.. 🤷♂️ doesn't make much sense to me. It's not consistent, also keylock mode could have changed since locking the key.
Removing that condition.
This is still WIP.
The issue was not discovered earlier because we didn't adjust the PitchRoundtrip test when we introduced the alternative keyunlock mode. I guess no one noticed in real life since it's an unusual combination to select "Reset to linear pitch" + "Lock current key" + have
pitch_adjustmapped.I'll try to adjust the test.