Skip to content

KeyControl: make 'Unlock, reset to linear pitch' always reset pitch_adjust #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronso0 wants to merge 1 commit into from
+4 −10
Closed

KeyControl: make 'Unlock, reset to linear pitch' always reset pitch_adjust #4758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/engine/controls/keycontrol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,18 +234,12 @@ void KeyControl::updateRate() {
m_pPitchAdjust->set(
KeyUtils::powerOf2ToSemitoneChange(m_pitchRateInfo.pitchTweakRatio));
} else { // Unlock and reset to linear pitch (orig. key + pitch fader offset)
// If 'current' aka 'not original' key was locked
// TODO(ronso0) Why does it depend on keylock mode?
if (m_keylockMode->get() == kLockCurrentKey) {
// reset to linear pitch
m_pitchRateInfo.pitchTweakRatio = 1.0;
// was missing?
// m_pPitchAdjust->set(
// KeyUtils::powerOf2ToSemitoneChange(m_pitchRateInfo.pitchTweakRatio));
}
m_pitchRateInfo.pitchTweakRatio = 1.0;
m_pPitchAdjust->set(
KeyUtils::powerOf2ToSemitoneChange(m_pitchRateInfo.pitchTweakRatio));
if constexpr (kEnableDebugOutput) {
qDebug() << " UNLOCKING reset to linear pitch";
qDebug() << " : pitchTweakRatio = 1.0";
qDebug() << " : pitchTweakRatio =" << m_pitchRateInfo.pitchTweakRatio;
qDebug() << " |";
}
}
Expand Down